Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[#94] Use Text in the simple-grep example to match changed Formatting API #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chshersh merged 14 commits into from
Jan 15, 2023
Merged

[#94] Use Text in the simple-grep example to match changed Formatting API #95

chshersh merged 14 commits into from
Jan 15, 2023

Conversation

@lillycham
Copy link
Contributor

@lillycham lillycham commented Oct 23, 2022 •
edited
Loading

Resolves #94
Also fixes build issue with #91

Additional tasks

  • Documentation for changes provided/changed
  • Tests added
  • Updated CHANGELOG.md

Lilly and others added 13 commits October 14, 2022 10:59
Change: ByteString > Text in Iris.Colour.Formatting
7a6b550
Update changelog to reflect changes in Iris.Colour.Formatting API
f519b62
Remove: bytestring dependency
aa06b85
@lillycham
Merge branch 'chshersh:main' into origin/byte-to-text
b391b1e
Move chshersh#90 unto unreleased section of changelog
e2e2c08
Merge branch 'origin/byte-to-text' of https://github.com/lillycat332/…
d4101b1 
…iris into origin/byte-to-text
Remove unneeded import in Iris.Colour.Formatting
7056b0e
@lillycham
Merge branch 'example-use-text' into origin/byte-to-text
c425c15
Merge pull request #1 from lillycat332/origin/byte-to-text
24d8d5c 
Origin/byte to text
Modify grep example to use Data.Text
142c31d
remove redundant imports
2393015 
replace bs.readfile with text
correct mdlint errors
56c41f1
Update changelog, remove bytestring dependency from grep.
276c63a
@lillycham lillycham requested a review from chshersh as a code owner October 23, 2022 09:50
@chshersh chshersh added the hacktoberfest-accepted https://hacktoberfest.com/participation/ label Oct 23, 2022
@chshersh
Copy link
Owner

chshersh commented Oct 23, 2022

@lillycat332 Do I understand correctly that #91 should be closed (currently it doesn't pass the CI) and this one should be merged instead?

@lillycham
Copy link
Contributor Author

lillycham commented Oct 23, 2022

@lillycat332 Do I understand correctly that #91 should be closed (currently it doesn't pass the CI) and this one should be merged instead?

Yes, this would resolve both of them, since it has the same commits as the pr #91

chshersh
chshersh approved these changes Jan 8, 2023
View reviewed changes
Copy link
Owner

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lillycat332 👋🏻

Apologies for taking too long with the review. The PR looks great 🏆

So if you can rebase it on top of the latest main, I'm happy to merge it 🎉

@chshersh chshersh merged commit 243151f into chshersh:main Jan 15, 2023
@chshersh chshersh mentioned this pull request Jan 15, 2023
Closed
@lillycham lillycham deleted the example-use-text branch January 17, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chshersh chshersh chshersh approved these changes

Assignees

@lillycham lillycham

Labels

hacktoberfest-accepted https://hacktoberfest.com/participation/

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use Data.Text instead of ByteString in simple-grep example to match the Text usage in Iris.Colour.Formatting

2 participants

@lillycham @chshersh