(/guides/add-onboarding-flow) Add code comment that explains user.reload() #1212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc: @JacobMGEvans |
JacobMGEvans
previously requested changes
Jul 1, 2024
alexisintech
reviewed
Jul 1, 2024
alexisintech
reviewed
Jul 1, 2024
Member
|
Please remove the callout and update the comment :) |
Co-authored-by: Alexis Aguilar <[email protected]>
Co-authored-by: Alexis Aguilar <[email protected]>
Contributor
Author
|
@alexisintech, thanks for you input :) All suggestions are implemented. |
alexisintech
reviewed
Jul 2, 2024
alexisintech
approved these changes
Jul 2, 2024
alexisintech
reviewed
Jul 2, 2024
Member
|
awesome change - thank you so much for pointing this out @abeisleem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
🔎 Previews:
Explanation:
It not easy to notice that developers should call
user.reload()on the frontend after updating the user'spublicMetadataon the backend when following the guide Add custom onboarding to your authentication flow. Making that call is a necessary part of the logic and has security implication depending on the use-case.Discord issue: https://discord.com/channels/856971667393609759/1253768303483162644
This PR:
user.reload()function call.