Keyring v2 #7033
Merged
Keyring v2 #7033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cd185b1 to
5488d0b
Compare
samcoe
commented
Feb 24, 2023
Comment on lines
-38
to
-41
| // TODO this probably shouldn't live in this package. It should probably be in a new package that | ||
| // depends on both iostreams and config. | ||
|
|
||
| // FIXME: this duplicates `factory.browserLauncher()` |
Contributor
Author
There was a problem hiding this comment.
Addressed both of these as part of the refactor by having the AuthFlow take a browser.Browser as an input and moving the writing of the config out of this flow and having the caller be responsible for writing it.
samcoe
commented
Feb 24, 2023
Comment on lines
+30
to
+34
| // This is deprecated and will be removed, do not use! | ||
| // Please use cfg.Authentication().Token() | ||
| AuthToken(string) (string, string) | ||
| // This is deprecated and will be removed, do not use! | ||
| // Please use cfg.Authentication().DefaultHost() | ||
| DefaultHost() (string, string) |
Contributor
Author
There was a problem hiding this comment.
Would have removed these but it would have ballooned the size of this PR. Will do it in a follow up cleanup PR.
samcoe
commented
Feb 24, 2023
Comment on lines
+136
to
+137
| hostsOverride func() []string | ||
| tokenOverride func(string) (string, string) |
Contributor
Author
There was a problem hiding this comment.
I tried a new approach here to have the overrides live inside the struct rather than create an interface that can be mocked out. Any function that calls a ghAuth can have an override.
Merged
vilmibm
approved these changes
Feb 27, 2023
| // Login will set user, git protocol, and auth token for the given hostname. | ||
| // If the encrypt option is specified it will first try to store the auth token | ||
| // in encrypted storage and will fall back to the plain text config file. | ||
| func (c *AuthConfig) Login(hostname, username, token, gitProtocol string, encrypt bool) error { |
Contributor
There was a problem hiding this comment.
i'm assuming the encrypt flag will be implemented in a follow up?
This comment was marked as spam.
This comment was marked as spam.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR breaks up the
Configinterface and moves authentication methods into the newAuthConfig. This is done to make it easy to implement encrypted token storage. Essentially in any of theauthcode we can now useAuthConfiginstead ofConfig. There are no functional changes here and all test changes are done to now stub/mock outAuthConfiginstead ofConfig.supersedes: #7023
follow up: #7043
cc: #449