Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Prepend PR body defaults to the selected template (if any) #1611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 9, 2020
Merged

Prepend PR body defaults to the selected template (if any) #1611

merged 4 commits into from
Sep 9, 2020

Conversation

@dhleong
Copy link
Contributor

@dhleong dhleong commented Sep 1, 2020

See #1570

Thought I'd go ahead and get the ball rolling with a simple change to address at least part of the issue linked above :)

@vilmibm vilmibm mentioned this pull request Sep 1, 2020
Closed
vilmibm
vilmibm suggested changes Sep 8, 2020
View reviewed changes
Copy link
Contributor

@vilmibm vilmibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh, unfortunately I just merged #1582 and, after merging trunk with this PR, the tests are failing. Sorry about that timing, but once this is reconciled with trunk I'm 👍

@dhleong
Prepend PR body defaults to the selected template (if any)
c422745 
See cli#1570
@dhleong
Add a test to verify the behavior of prepending commit body to message
a331244
@dhleong
"Check" the error value of ioutil.WriteFile
41543b5 
We could, alternatively, use t.Fatal... this matches the MkdirAll
invocation from github_template_test, however...
@dhleong
Update template test to reflect inclusion of "default" text
c7e7022 
Also, avoid excessive amounts of newlines separating the two
@dhleong dhleong force-pushed the dhleong/pr-prepend-commit-bodies branch from 42fc8dd to c7e7022 Compare September 9, 2020 00:26
@dhleong
Copy link
Contributor Author

dhleong commented Sep 9, 2020

Based against trunk, updated the failing test to reflect the inclusion of the "default" body before the template, and also added some quick logic to avoid having more than two newlines separating the template text and the "default" body.

@vilmibm vilmibm self-requested a review September 9, 2020 16:00
vilmibm
vilmibm approved these changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@vilmibm vilmibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!!

@vilmibm vilmibm merged commit 33e11f0 into cli:trunk Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@vilmibm vilmibm vilmibm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dhleong @vilmibm