Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix issue label overrides caused by pagination #2190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 15, 2020
Merged

Fix issue label overrides caused by pagination #2190

merged 3 commits into from
Oct 15, 2020
+94 −9

Conversation

@quiye
Copy link
Contributor

@quiye quiye commented Oct 14, 2020

Fixes #1443

Thankfully, my commits were partially reviewed by @mislav in quiye#2

@quiye quiye mentioned this pull request Oct 14, 2020
Closed
quiye and others added 2 commits October 14, 2020 15:32
@quiye @mislav
Fix parsing labels in paginated IssueList
a90b62f
@mislav
Ensure that we don't reuse the same deserialization struct over pagin…
813fbc9 
…ation iterations

This is to avoid subtle deserialization issues in nested slices.
mislav
mislav approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!! 🌟

I've pushed commits that simplify your original changeset (so that the diff is minimal), make the test more readable, and address the same issue in other pagination instances where we reused the same struct.

@quiye
Copy link
Contributor Author

quiye commented Oct 14, 2020

@mislav It looks great to me. Thank you!

@mislav mislav merged commit 02f4946 into cli:trunk Oct 15, 2020
@quiye quiye deleted the issues-data-race branch October 22, 2020 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mislav mislav mislav approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Issue list Labels change with limit Parameter

2 participants

@quiye @mislav