Add a pagination test for IssueList #2
Conversation
|
bd097a9 As expected, added test is failed. See the result of GitHub Actions. |
api/queries_issue.go
Outdated
| loop: | ||
| for { | ||
| variables["limit"] = pageLimit | ||
| var response struct { |
There was a problem hiding this comment.
To avoid redeclaring this struct completely in every loop iteration, do you think your approach would also work if this struct was defined as a type outside of a loop, and response was created inside a loop here as an instance of that type?
There was a problem hiding this comment.
Thank you for your review.
I think my approach works even if the type (struct) is defined outside the loop.
After response is defined in each loop and the data is parsed into response, issues share the array referenced by the response until the next loop, but when moving to the next loop, response goes out of scope and destructed. Therefore, the array is only referenced by issues, not the same array in the next loop.
So it's okay to declare the type (struct) outside the loop. It seems that the loop code is easier to read.
api/queries_issue_test.go
Outdated
| }, | ||
| } | ||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { |
There was a problem hiding this comment.
Does this need to be a table-based test since it only contains a single test case?
There was a problem hiding this comment.
Not necessary. I'll fix this.
|
I made a Pull Request to original repository cli#2190 |
Added test is expeceted to fail by data overwriting.