Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 30, 2025

Fixes CI failures in #865 by updating test assertions for mime-types v3 breaking change.

Breaking Change in mime-types v3

Per RFC 9239, JavaScript MIME type changed from application/javascript to text/javascript:

// mime-types v2
mime.lookup('index.js') // => 'application/javascript'

// mime-types v3
mime.lookup('index.js') // => 'text/javascript'

Changes

  • package.json: Update mime-types to ^3.0.2 and @types/mime-types to ^3.0.1
  • test/port/controller/PackageVersionFileController/raw.test.ts: Update content-type assertions
  • test/port/controller/PackageVersionFileController/listFiles.test.ts: Update contentType field assertions

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com//advisories
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

fix #865, update mime-types to v3


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 30, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

@graphite-app
Copy link

graphite-app bot commented Nov 30, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • MQ - adds this PR to the back of the merge queue
  • Hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@socket-security
Copy link

socket-security bot commented Nov 30, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​types/​mime-types@​2.1.4 ⏵ 3.0.110010067 +381100

View full report

Copilot AI changed the title [WIP] Fix update of mime-types to version 3 fix: update mime-types to v3 Nov 30, 2025
Copilot AI requested a review from fengmk2 November 30, 2025 12:32
@codecov
Copy link

codecov bot commented Nov 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.25%. Comparing base (dc20401) to head (227de04).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #899      +/-   ##
==========================================
- Coverage   95.37%   95.25%   -0.12%     
==========================================
  Files         197      197              
  Lines       22100    22100              
  Branches     2444     2598     +154     
==========================================
- Hits        21077    21052      -25     
- Misses       1023     1048      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fengmk2 fengmk2 marked this pull request as ready for review November 30, 2025 15:03
@fengmk2 fengmk2 changed the title fix: update mime-types to v3 chore(deps): update mime-types to v3 Dec 1, 2025
@fengmk2 fengmk2 merged commit 0a5c90c into master Dec 6, 2025
27 of 28 checks passed
@fengmk2 fengmk2 deleted the copilot/update-mime-types-to-v3 branch December 6, 2025 13:21
fengmk2 pushed a commit that referenced this pull request Dec 6, 2025
[skip ci]

## <small>4.13.3 (2025-12-06)</small>

* fix: zero copy to create a new Buffer (#916) ([683ee1d](683ee1d)), closes [#916](#916) [hi#level](https://github.com/hi/issues/level)
* chore(deps): update mime-types to v3 (#899) ([0a5c90c](0a5c90c)), closes [#899](#899) [#865](#865)
* chore(deps): upgrade base-x to v5 (#897) ([d3e4fae](d3e4fae)), closes [#897](#897) [#864](#864)
@github-actions
Copy link

github-actions bot commented Dec 6, 2025

🎉 This PR is included in version 4.13.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants