Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: artifacts upload #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 24, 2025
Merged

fix: artifacts upload #80

merged 3 commits into from
Apr 24, 2025

Conversation

@elrrrrrrr
Copy link
Member

@elrrrrrrr elrrrrrrr commented Apr 24, 2025 •
edited by coderabbitai bot
Loading

Sweep Summary Sweep

Fixes artifact upload issues in the release workflow by adding architecture-specific suffixes to artifact names and upgrading the upload-artifact action to v4.

  • Updated actions/upload-artifact and actions/download-artifact from v3 to v4 in the GitHub workflow file.
  • Added architecture-specific suffixes to artifact names (e.g., linux-binding-release-${{ matrix.arch }}) to prevent name collisions during uploads.
  • Updated version to 0.4.2 in lerna.json and added corresponding entries in all CHANGELOG.md files.
  • Added a feature note about "single mount" in the main CHANGELOG.md and packages/cli/CHANGELOG.md.

Ask Sweep AI questions about this PR

  • fix duplicate artifact names when upload

Summary by CodeRabbit

  • New Features

    • Introduced the "single mount" feature.

  • Chores

    • Updated package versions to 0.4.2 across all relevant packages.
    • Synchronized dependency versions for platform-specific bindings.
    • Improved artifact handling in release workflows to be architecture-specific.

@elrrrrrrr elrrrrrrr added the documentation Improvements or additions to documentation label Apr 24, 2025
@elrrrrrrr elrrrrrrr requested a review from killagu April 24, 2025 16:04
@coderabbitai
Copy link

coderabbitai bot commented Apr 24, 2025 •
edited
Loading

Walkthrough

This update increments the version numbers of several packages and their dependencies from 0.4.1 to 0.4.2, reflecting a new release. Changelog files for the main project and platform-specific bindings are updated to document the new version, with a particular note of a "single mount" feature in the main changelogs. The GitHub Actions workflow is modified to use version 4 of the upload-artifact and download-artifact actions, and artifact naming is adjusted to include architecture information. No changes are made to exported or public code entities.

Changes

Files/Paths Change Summary
.github/workflows/release.yml Updated artifact actions from v3 to v4; artifact names now include architecture; download steps updated.
CHANGELOG.md, packages/cli/CHANGELOG.md Added 0.4.2 release entry noting "single mount" feature.
lerna.json Bumped version from 0.4.1 to 0.4.2.
packages/cli/package.json Updated @cnpmjs/rapid version and dependency on @cnpmjs/binding to 0.4.2.
packages/binding/package.json Updated version to 0.4.2; updated optional dependencies for all platform bindings to ^0.4.2.
bindings/binding-*/package.json Updated version from 0.4.1 to 0.4.2 for each platform-specific binding.
bindings/binding-*/CHANGELOG.md, packages/binding/CHANGELOG.md Added 0.4.2 changelog entries noting version bump for each binding package; no other changes documented.

Sequence Diagram(s)

sequenceDiagram
    participant Workflow
    participant GitHub Actions
    participant Artifact Store

    Workflow->>GitHub Actions: Run release workflow
    GitHub Actions->>Artifact Store: Upload artifact (v4, name includes arch)
    GitHub Actions->>Artifact Store: Download artifact (v4, name includes arch)
Loading

Possibly related PRs

  • chore: artifact action v4 #79: Updates the GitHub Actions artifact upload and download steps from v3 to v4, directly related to the workflow changes in this PR.

Suggested reviewers

  • killagu
  • akitaSummer

Poem

Hopping along, a version anew,
0.4.2 is here—bindings in queue!
Artifacts now smarter, arch in their name,
Workflows updated, releases the same.
Changelogs refreshed, a single mount’s fame,
The garden of code grows—onward we aim!

((\
( -.-)
o_(")(")

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 783b400 and 1a05e66.

📒 Files selected for processing (15)
  • .github/workflows/release.yml (5 hunks)
  • CHANGELOG.md (1 hunks)
  • bindings/binding-darwin-amd64/CHANGELOG.md (1 hunks)
  • bindings/binding-darwin-amd64/package.json (1 hunks)
  • bindings/binding-darwin-arm64/CHANGELOG.md (1 hunks)
  • bindings/binding-darwin-arm64/package.json (1 hunks)
  • bindings/binding-linux-amd64/CHANGELOG.md (1 hunks)
  • bindings/binding-linux-amd64/package.json (1 hunks)
  • bindings/binding-linux-arm64/CHANGELOG.md (1 hunks)
  • bindings/binding-linux-arm64/package.json (1 hunks)
  • lerna.json (1 hunks)
  • packages/binding/CHANGELOG.md (1 hunks)
  • packages/binding/package.json (2 hunks)
  • packages/cli/CHANGELOG.md (1 hunks)
  • packages/cli/package.json (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (10)
  • GitHub Check: macos-test (20.x, bash)
  • GitHub Check: macos-test (16.x, bash)
  • GitHub Check: linux-ci (18.x, ubuntu-22.04, bash)
  • GitHub Check: linux-test (20.x, ubuntu-22.04, bash, 3.9)
  • GitHub Check: macos-test (18.x, bash)
  • GitHub Check: linux-ci (16.x, ubuntu-22.04, bash)
  • GitHub Check: linux-test (16.x, ubuntu-22.04, bash, 3.9)
  • GitHub Check: linux-ci (20.x, ubuntu-22.04, bash)
  • GitHub Check: linux-test (18.x, ubuntu-22.04, bash, 3.9)
  • GitHub Check: build (ubuntu-22.04, bash)
🔇 Additional comments (19)
lerna.json (1)

2-2: Approve version bump in lerna.json.
The version field has been correctly updated to 0.4.2 to align with the coordinated release.

bindings/binding-darwin-arm64/package.json (1)

3-3: Approve version bump for darwin-arm64 binding.
The version has been updated to 0.4.2 to match the new release across all packages.

bindings/binding-linux-arm64/package.json (1)

3-3: Approve version bump for linux-arm64 binding.
The version has been updated to 0.4.2, consistent with the overall release.

bindings/binding-darwin-amd64/package.json (1)

3-3: Approve version bump for darwin-amd64 binding.
The version field is correctly updated to 0.4.2 in line with the coordinated release.

bindings/binding-linux-amd64/package.json (1)

3-3: Approve version bump for linux-amd64 binding.
The version has been bumped to 0.4.2, matching the other platform bindings.

CHANGELOG.md (2)

6-7: Add changelog entry for 0.4.2
The new section for version 0.4.2 dated 2025-04-24 is correctly inserted. It follows the Conventional Commits format and links to the comparison range.

11-11: Document "single mount" feature
The feature entry for issue #77 and its commit reference is accurately recorded under the Features header.

packages/cli/CHANGELOG.md (2)

6-7: Add CLI changelog entry for 0.4.2
The CLI changelog has been updated with the new version header and date, maintaining consistency with the root CHANGELOG.

11-11: Record CLI "single mount" feature
The CLI-specific feature entry correctly mirrors the new functionality introduced in version 0.4.2.

packages/cli/package.json (2)

3-3: Bump package version to 0.4.2
The version field is updated to 0.4.2, aligning with the release documented in the changelogs.

14-14: Upgrade @cnpmjs/binding dependency
Dependency on @cnpmjs/binding has been updated to ^0.4.2 to match the binding package release.

bindings/binding-linux-amd64/CHANGELOG.md (1)

6-8: Version bump for linux-amd64 binding to 0.4.2
The entry for 0.4.2 with a note indicating a version-only bump is correctly added.

bindings/binding-darwin-amd64/CHANGELOG.md (1)

6-8: Version bump for darwin-amd64 binding to 0.4.2
The entry for 0.4.2 with a note indicating a version-only bump is correctly added.

packages/binding/CHANGELOG.md (1)

6-9: Changelog entry for 0.4.2 looks good

The new version section is correctly formatted with compare link and date.

bindings/binding-linux-arm64/CHANGELOG.md (1)

6-9: Changelog bump entry correct

Entry for version 0.4.2 is properly formatted and notes the version bump only for the linux-arm64 binding.

bindings/binding-darwin-arm64/CHANGELOG.md (1)

6-9: Changelog bump entry correct

Entry for version 0.4.2 is properly formatted and notes the version bump only for the darwin-arm64 binding.

packages/binding/package.json (1)

3-4: Version and optionalDependencies updated correctly

Package version has been bumped to 0.4.2, and all platform-specific optional dependencies have had their version ranges updated to ^0.4.2.

Also applies to: 21-24

.github/workflows/release.yml (2)

83-86: Upload-artifact steps updated correctly

Switched to actions/upload-artifact@v4 and ensured artifact names include ${{ matrix.arch }} for both Linux and macOS builds, preventing name collisions during parallel uploads.

Also applies to: 163-166, 223-226

306-324: Download-artifact steps aligned with uploads

Updated to actions/download-artifact@v4 and artifact names now match the new upload names (linux-binding-release-…, macos-binding-release-…, etc.), resolving duplicate artifact retrieval issues.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@elrrrrrrr elrrrrrrr merged commit 5e45b6d into master Apr 24, 2025
13 checks passed
@elrrrrrrr elrrrrrrr deleted the fix-artifact branch April 24, 2025 16:20
@sweep-ai-deprecated sweep-ai-deprecated bot mentioned this pull request Apr 24, 2025
Merged
This was referenced Apr 27, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@killagu killagu killagu approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@elrrrrrrr @killagu