Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: arm64 release #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 27, 2025
Merged

chore: arm64 release #82

merged 4 commits into from
Apr 27, 2025

Conversation

@elrrrrrrr
Copy link
Member

@elrrrrrrr elrrrrrrr commented Apr 27, 2025 •
edited by coderabbitai bot
Loading

  • 🛠 Fix package release issues on arm64 architecture

https://github.com/cnpm/rapid/actions/runs/14687597459/job/41218378145

Summary by CodeRabbit

  • Chores
    • Updated workflow to simplify architecture handling and artifact downloads during the release process. No user-facing changes.

@elrrrrrrr elrrrrrrr added the documentation Improvements or additions to documentation label Apr 27, 2025
@elrrrrrrr elrrrrrrr requested a review from killagu April 27, 2025 02:54
@coderabbitai
Copy link

coderabbitai bot commented Apr 27, 2025 •
edited
Loading

Walkthrough

The release workflow configuration was updated by removing the matrix strategy for architectures from the release job. Instead of iterating over architectures using a matrix, the workflow now includes explicit steps for downloading artifacts for both amd64 and arm64 architectures for macOS and Linux. The references to matrix variables were replaced with hardcoded architecture values, and the artifact download paths were set directly. No changes were made to exported or public entities, and no other control flow or error handling modifications were introduced.

Changes

File(s) Change Summary
.github/workflows/release.yml Removed matrix strategy for architectures in the release job; replaced matrix variables with explicit steps for downloading macOS and Linux artifacts for amd64 and arm64; set artifact download paths to packages; added a commented-out tag pattern for workflow triggers.

Sequence Diagram(s)

sequenceDiagram
    participant GitHub Actions
    participant Artifact Store

    GitHub Actions->>Artifact Store: Download macOS binding artifact (amd64) to packages
    GitHub Actions->>Artifact Store: Download macOS binding artifact (arm64) to packages
    GitHub Actions->>Artifact Store: Download Linux binding artifact (amd64) to packages
    GitHub Actions->>Artifact Store: Download Linux binding artifact (arm64) to packages
Loading

Possibly related PRs

  • fix: artifacts upload #80: Updates artifact upload and download steps to use architecture-specific artifact names with matrix variables, which is closely related as both PRs modify artifact handling in the same workflow file but focus on different aspects.

Poem

In the warren of workflows, a change hops through,
No more matrix to chase, just steps to pursue.
Each arch gets its turn, explicit and neat,
Artifacts gathered, a release complete!
With paws on the keyboard and code in the air,
This rabbit approves—automation with care! 🐇✨

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Apr 27, 2025
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
.github/workflows/release.yml (2)

6-7: Confirm the commented-out test tag filter
You’ve added # - "test-v*" under on.push.tags. Please verify whether you intend to support test tags in your release workflow. If not needed, consider removing it to avoid confusion; otherwise, uncomment and adjust the pattern to match your test-tag convention.

314-329: Reduce duplication in download-artifact steps
There’s considerable repetition across the four explicit download steps. Consider using YAML anchors or a small reusable snippet for uses: actions/download-artifact@v4 and the with: path: packages block, then override only the name field for each architecture. This will improve maintainability when adding new platforms or adjusting common settings.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f4ff788 and 4b80881.

📒 Files selected for processing (1)
  • .github/workflows/release.yml (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (10)
  • GitHub Check: macos-test (20.x, bash)
  • GitHub Check: macos-test (16.x, bash)
  • GitHub Check: macos-test (18.x, bash)
  • GitHub Check: linux-ci (20.x, ubuntu-22.04, bash)
  • GitHub Check: linux-ci (18.x, ubuntu-22.04, bash)
  • GitHub Check: linux-ci (16.x, ubuntu-22.04, bash)
  • GitHub Check: linux-test (20.x, ubuntu-22.04, bash, 3.9)
  • GitHub Check: linux-test (18.x, ubuntu-22.04, bash, 3.9)
  • GitHub Check: linux-test (16.x, ubuntu-22.04, bash, 3.9)
  • GitHub Check: build (ubuntu-22.04, bash)
🔇 Additional comments (4)
.github/workflows/release.yml (4)

314-315: Validate macOS AMD64 artifact download
The name: macos-binding-release-amd64 matches the upload step and will pull in the correct artifact.

317-319: Validate macOS ARM64 artifact download
The name: macos-binding-release-arm64 is correct and aligns with the upload.

324-325: Validate Linux AMD64 artifact download
The name: linux-binding-release-amd64 matches the corresponding upload-artifact step.

327-329: Validate Linux ARM64 artifact download
The name: linux-binding-release-arm64 is correct and consistent with the upload.

killagu
killagu approved these changes Apr 27, 2025
View reviewed changes
Copy link
Contributor

@killagu killagu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elrrrrrrr elrrrrrrr merged commit 52716a3 into master Apr 27, 2025
13 checks passed
@elrrrrrrr elrrrrrrr deleted the chore-fix-amd64-release branch April 27, 2025 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@killagu killagu killagu approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@elrrrrrrr @killagu