Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@souvlakias
Copy link
Contributor

@souvlakias souvlakias commented Jun 30, 2025

Extension PR of #5392, resolves #5392 (review)
Notes:

  • Added an Android Dummy module since it has a different dependency resolution (MavenRepo)
  • In build info we extract not the whole maven dep but just the versions, so they can be easily overridden.

Thanks @lefou for your draft, and please let me know if there's anything to fix/add.

@souvlakias souvlakias changed the title Android lib build info auto update Android: add android libs to dummyAndroid module for auto update Jun 30, 2025
@souvlakias souvlakias marked this pull request as ready for review June 30, 2025 13:04
lihaoyi and others added 8 commits July 1, 2025 10:08
…#5400)

Works around com-lihaoyi#5375

I still don't know why it happens, but it's happened multiple times, and
in any case it should be fine to ignore the error

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Since Mill is on Scala 3, it's time for the examples to be Scala 3 as
well. Also bumped library versions in the examples

Left a few on Scala 2 where the upgrade was a bit fiddly (e.g. dealing
with fatal warnings, compiler plugins, etc.)
- `mill.vcs` needs to be stable
- `mill.tabcomplete` does not need to be stable
- `mill.scalanativelib`, `mill.scalajslib`, `mill.kotlinlib` can
probably be stable by now
…om-lihaoyi#5407)

- `core/api/` has been moved to `core/api/shared/`, under
`mill.api.shared`
- `core/define/`  has been moved to `core/api/`, under `mill.api`
- `mill.api` now has explicit exports for the relevant user-facing
classes in `mill.api.shared`

The goal of this is to eliminate the user-facing split between
`mill.define` and `mill.api`. Previously, the split was purely based on
the internal concerns of what classes are necessary to interface with
`mill.daemon`, and is totally irrelevant to the user. This causes
confusion in where to find things, since it's generally impossible to
remember what lives in which one

This change unifies the user-facing API under `mill.api`, while keeping
the backend split of `core/api` and `core/api/shared` to accommodate the
separation necessary internally. Now users can directly import stuff
from `mill.api` all the time, and whether the actual implementation
lives in `mill.api` or `mill.api.shared` doesn't really matter since
everything that lives elsewhere is re-exported

For now the number of things exported from `import mill.api._` and
`import mill._` is somewhat arbitrary, but we can add more exports later
if necessary
@lefou
Copy link
Member

lefou commented Jul 1, 2025

This PR changes 595 files. Looks like a git merge gone wrong. Can you please rebase on latest main?

Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@lefou
Copy link
Member

lefou commented Jul 1, 2025

@souvlakias The ci/mill-bootstrap.patch needs to be updated. I tried to push the required changes, but it seem you didn't allow maintainers to push to your PR-branch.

@vaslabs
Copy link
Contributor

vaslabs commented Jul 1, 2025

@souvlakias The ci/mill-bootstrap.patch needs to be updated. I tried to push the required changes, but it seem you didn't allow maintainers to push to your PR-branch.

The settings are a bit different in our org, I gave you access to our fork @lefou , please try again (you should have received an invite)

@lihaoyi lihaoyi merged commit 2556b60 into com-lihaoyi:main Jul 1, 2025
38 of 39 checks passed
@lefou lefou added this to the 1.0.0-RC3 milestone Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants