Android: Replace hardcoded versions with relevant versions from build info #5392
Conversation
souvlakias
commented
Jun 27, 2025
- Extracted hardcoded values of each android module subclass into the build info component of androidlib
| object AndroidDeps { | ||
| val manifestMergerVersion = "31.10.0" | ||
| val bundleToolVersion = "1.17.2" | ||
| val ndkVersion = "27.0.12077973" | ||
| val cmakeVersion = "3.22.1" | ||
| val layoutLibVersion = "15.1.2" | ||
| val composePreviewRendererVersion = "0.0.1-alpha09" | ||
| val uiToolingVersion = "1.7.6" | ||
| } |
There was a problem hiding this comment.
What's missing here is to also use these dependencies somewhere, so we can auto-detect updates. Please add these to the dummy cross module in the top-level build.mill.
There was a problem hiding this comment.
cool, we'll do, what happens for the tools that we can't match to maven deps? (I think it's just cmake and ndk)
Is it better to have those in package.mill instead?
There was a problem hiding this comment.
Currently, nothing. If you have an idea how to check them for updates, you can add a task that check it, of course.
I already started to add some deps to the dummy module. I'll send a review request.
There was a problem hiding this comment.
Here's my draft:
@vaslabs Don't know, if we need to accommodate to Android specifics. Feel free to comment or push to that PR branch.
There was a problem hiding this comment.
no worries, @souvlakias is on it, he's also referencing the dependencies where appropriate (e.g. for layout lib and compose renderer)
There was a problem hiding this comment.
we can do the android specifics later, for now let's go for the easy maven deps. We'll need to do some investigation for those as some of them depend on the android Sdk too.
There was a problem hiding this comment.
If we need to customize the repos or other stuff, just create a second dummy module.
…5399) Extension PR of #5392, resolves #5392 (review) Notes: - Added an Android Dummy module since it has a different dependency resolution (MavenRepo) - In build info we extract not the whole maven dep but just the versions, so they can be easily overridden. Thanks @lefou for your [draft](#5397), and please let me know if there's anything to fix/add. --------- Co-authored-by: Li Haoyi <[email protected]> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Tobias Roeser <[email protected]>