Implement PEAR support. #3

xaav · 2011-06-28T00:22:36Z

This implements PEAR support. Yes, this uses the work that @beberlei did, but he no longer appears to be interested in implementing this.

I also understand that this needs to be modified to make the PEARRepository integrate into the ComposerRepository or something?

Thanks.

…n would look like {"repositories":{"doctrine": {"pear":"http://pear.doctrine-project.org"},"requires":{"DoctrineORM":"2.0.5"}}. You can use pear repositories this way for now. PEAR packages are not downloaded via pear, only via their .tgz packages in the PEAR repository. Automatically detecting dependencies will require reverse-engineering the PEAR protocol a little bit more, however from looking at a pirum output it looks simple.

…f, taking longer then pear remote-list, but at least showing ALL available versions, making arbitrary dependencies possible.

Seldaek · 2011-06-28T19:31:00Z

Doh, rebased the commits by mistake when updating the README fix. It's merged.

Improve 'getTags()' and 'getBranches()'

Tweak option composer#3 for including dependencies in a GIT repo.

Fixing perforce driver/downloader bugs

The default value for the `preg_split()` `$limit` parameter is `-1`, not `null`. Fixes numerous `preg_split(): Passing null to parameter composer#3 ($limit) of type int is deprecated` notices when running the test suite. Ref: https://www.php.net/manual/en/function.preg-split.php

Discovered while running the existing unit tests on PHP 8.1. Fixes: ``` Deprecation triggered by Composer\Test\DependencyResolver\PoolBuilderTest::testPoolBuilder: preg_match(): Passing null to parameter composer#2 ($subject) of type string is deprecated Stack trace: #0 [internal function]: Symfony\Bridge\PhpUnit\DeprecationErrorHandler->handleError(8192, '...', '...', 597) composer#1 src/Composer/Package/Package.php(597): preg_match('...', NULL) composer#2 src/Composer/DependencyResolver/PoolBuilder.php(360): Composer\Package\Package->setSourceDistReferences('...') composer#3 src/Composer/DependencyResolver/PoolBuilder.php(338): Composer\DependencyResolver\PoolBuilder->loadPackage(Object(Composer\DependencyResolver\Request), Object(Composer\Package\CompletePackage)) composer#4 src/Composer/DependencyResolver/PoolBuilder.php(195): Composer\DependencyResolver\PoolBuilder->loadPackagesMarkedForLoading(Object(Composer\DependencyResolver\Request), Array) composer#5 src/Composer/Repository/RepositorySet.php(229): Composer\DependencyResolver\PoolBuilder->buildPool(Array, Object(Composer\DependencyResolver\Request)) composer#6 tests/Composer/Test/DependencyResolver/PoolBuilderTest.php(110): Composer\Repository\RepositorySet->createPool(Object(Composer\DependencyResolver\Request), Object(Composer\IO\NullIO)) ... ```

The default value for the `preg_split()` `$limit` parameter is `-1`, not `null`. Fixes numerous `preg_split(): Passing null to parameter composer#3 ($limit) of type int is deprecated` notices when running the test suite. Ref: https://www.php.net/manual/en/function.preg-split.php

The return type of the `Rule::getRequiredPackage()` method effectively was `?string` as if no matching reason was found, the function wasn't returning anything. In PHP 8.1, this results in the following notice from existing tests: ``` Deprecation triggered by Composer\Test\DependencyResolver\SolverTest::testConflictResultEmpty: strpos(): Passing null to parameter composer#1 ($haystack) of type string is deprecated Stack trace: #0 [internal function]: Symfony\Bridge\PhpUnit\DeprecationErrorHandler->handleError(8192, '...', '...', 111) composer#1 src/Composer/DependencyResolver/SolverProblemsException.php(111): strpos(NULL, '...') composer#2 src/Composer/DependencyResolver/SolverProblemsException.php(44): Composer\DependencyResolver\SolverProblemsException->hasExtensionProblems(Array) composer#3 tests/Composer/Test/DependencyResolver/SolverTest.php(659): Composer\DependencyResolver\SolverProblemsException->getPrettyString(Object(Composer\Repository\RepositorySet), Object(Composer\DependencyResolver\Request), Object(Composer\DependencyResolver\Pool), false) .... ``` Fixed by returning an empty string if no reason was matched.

The default value for the `preg_split()` `$limit` parameter is `-1`, not `null`. Fixes numerous `preg_split(): Passing null to parameter composer#3 ($limit) of type int is deprecated` notices when running the test suite. Ref: https://www.php.net/manual/en/function.preg-split.php

Discovered while running the existing unit tests on PHP 8.1. Fixes: ``` Deprecation triggered by Composer\Test\Downloader\FossilDownloaderTest::testUpdate: trim(): Passing null to parameter composer#1 ($string) of type string is deprecated Stack trace: #0 [internal function]: Symfony\Bridge\PhpUnit\DeprecationErrorHandler->handleError(8192, '...', '...', 93) composer#1 src/Composer/Downloader/FossilDownloader.php(93): trim(NULL) composer#2 src/Composer/Downloader/VcsDownloader.php(267): Composer\Downloader\FossilDownloader->getLocalChanges(Object(Mock_PackageInterface_c17fec12), '...') composer#3 src/Composer/Downloader/VcsDownloader.php(99): Composer\Downloader\VcsDownloader->cleanChanges(Object(Mock_PackageInterface_c17fec12), '...', true) composer#4 tests/Composer/Test/Downloader/FossilDownloaderTest.php(143): Composer\Downloader\VcsDownloader->prepare('...', Object(Mock_PackageInterface_c17fec12), '...', Object(Mock_PackageInterface_c17fec12)) ... ```

The default value for the `preg_split()` `$limit` parameter is `-1`, not `null`. Fixes numerous `preg_split(): Passing null to parameter composer#3 ($limit) of type int is deprecated` notices when running the test suite. ``` Deprecation triggered by Composer\Test\Util\Http\ProxyManagerTest::testGetProxyForRequest: preg_split(): Passing null to parameter composer#3 ($limit) of type int is deprecated Stack trace: 0 [internal function]: Symfony\Bridge\PhpUnit\DeprecationErrorHandler->handleError(8192, '...', '...', 42) 1 src/Composer/Util/NoProxyPattern.php(42): preg_split('...', '...', NULL, 1) 2 src/Composer/Util/Http/ProxyManager.php(148): Composer\Util\NoProxyPattern->__construct('...') 3 src/Composer/Util/Http/ProxyManager.php(50): Composer\Util\Http\ProxyManager->initProxyData() 4 src/Composer/Util/Http/ProxyManager.php(59): Composer\Util\Http\ProxyManager->__construct() 5 tests/Composer/Test/Util/Http/ProxyManagerTest.php(75): Composer\Util\Http\ProxyManager::getInstance() ... ``` Ref: https://www.php.net/manual/en/function.preg-split.php

The default value for the `preg_split()` `$limit` parameter is `-1`, not `null`. Fixes numerous `preg_split(): Passing null to parameter composer#3 ($limit) of type int is deprecated` notices when running the test suite. Ref: https://www.php.net/manual/en/function.preg-split.php

The default value for the `preg_split()` `$limit` parameter is `-1`, not `null`. Fixes some `preg_split(): Passing null to parameter composer#3 ($limit) of type int is deprecated` notices when running the test suite. ``` Deprecation triggered by Composer\Test\Util\Http\ProxyManagerTest::testGetProxyForRequest: preg_split(): Passing null to parameter composer#3 ($limit) of type int is deprecated Stack trace: 0 [internal function]: Symfony\Bridge\PhpUnit\DeprecationErrorHandler->handleError(8192, '...', '...', 42) 1 src/Composer/Util/NoProxyPattern.php(42): preg_split('...', '...', NULL, 1) 2 src/Composer/Util/Http/ProxyManager.php(148): Composer\Util\NoProxyPattern->__construct('...') 3 src/Composer/Util/Http/ProxyManager.php(50): Composer\Util\Http\ProxyManager->initProxyData() 4 src/Composer/Util/Http/ProxyManager.php(59): Composer\Util\Http\ProxyManager->__construct() 5 tests/Composer/Test/Util/Http/ProxyManagerTest.php(75): Composer\Util\Http\ProxyManager::getInstance() ... ``` Ref: https://www.php.net/manual/en/function.preg-split.php

The default value for the `preg_split()` `$limit` parameter is `-1`, not `null`. Fixes numerous `preg_split(): Passing null to parameter composer#3 ($limit) of type int is deprecated` notices when running the test suite. Ref: https://www.php.net/manual/en/function.preg-split.php

The default value for the `preg_split()` `$limit` parameter is `-1`, not `null`. Fixes numerous `preg_split(): Passing null to parameter composer#3 ($limit) of type int is deprecated` notices when running the test suite. ``` Deprecation triggered by Composer\Test\Util\Http\ProxyManagerTest::testGetProxyForRequest: preg_split(): Passing null to parameter composer#3 ($limit) of type int is deprecated Stack trace: 0 [internal function]: Symfony\Bridge\PhpUnit\DeprecationErrorHandler->handleError(8192, '...', '...', 42) 1 src/Composer/Util/NoProxyPattern.php(42): preg_split('...', '...', NULL, 1) 2 src/Composer/Util/Http/ProxyManager.php(148): Composer\Util\NoProxyPattern->__construct('...') 3 src/Composer/Util/Http/ProxyManager.php(50): Composer\Util\Http\ProxyManager->initProxyData() 4 src/Composer/Util/Http/ProxyManager.php(59): Composer\Util\Http\ProxyManager->__construct() 5 tests/Composer/Test/Util/Http/ProxyManagerTest.php(75): Composer\Util\Http\ProxyManager::getInstance() ... ``` Ref: https://www.php.net/manual/en/function.preg-split.php

The default value for the `ProcessExecutor::$errorOutput` property is `null`, so the return value of `$this->process->getErrorOutput()` could well be `null`. In that case, we may as well bypass the whole `foreach` as it will never match any of the recognized authentication failure messages. Fixes: ``` Deprecation triggered by Composer\Test\Downloader\GitDownloaderTest::testDownloadThrowsRuntimeExceptionIfGitCommandFails: strpos(): Passing null to parameter composer#1 ($haystack) of type string is deprecated Stack trace: #0 [internal function]: Symfony\Bridge\PhpUnit\DeprecationErrorHandler->handleError(8192, '...', '...', 340) composer#1 src/Composer/Util/Git.php(340): strpos(NULL, '...') composer#2 src/Composer/Util/Git.php(200): Composer\Util\Git->isAuthenticationFailure('...', Array) composer#3 src/Composer/Downloader/GitDownloader.php(121): Composer\Util\Git->runCommand(Object(Closure), '...', NULL, true) composer#4 src/Composer/Downloader/VcsDownloader.php(137): Composer\Downloader\GitDownloader->doInstall(Object(Mock_PackageInterface_f8be9ebd), '...', '...') composer#5 tests/Composer/Test/Downloader/GitDownloaderTest.php(349): Composer\Downloader\VcsDownloader->install(Object(Mock_PackageInterface_f8be9ebd), '...') ... ```

Fixes: ``` Deprecation triggered by Composer\Test\Installer\LibraryInstallerTest::testUninstall: strpos(): Passing null to parameter composer#1 ($haystack) of type string is deprecated Stack trace: #0 [internal function]: Symfony\Bridge\PhpUnit\DeprecationErrorHandler->handleError(8192, '...', '...', 202) composer#1 src/Composer/Installer/LibraryInstaller.php(202): strpos(NULL, '...') composer#2 vendor/react/promise/src/FulfilledPromise.php(28): Composer\Installer\LibraryInstaller->Composer\Installer\{closure}(NULL) composer#3 src/Composer/Installer/LibraryInstaller.php(208): React\Promise\FulfilledPromise->then(Object(Closure)) composer#4 tests/Composer/Test/Installer/LibraryInstallerTest.php(221): Composer\Installer\LibraryInstaller->uninstall(Object(Mock_InstalledRepositoryInterface_e3699f95), Object(Mock_Package_e4571076)) ... ```

…ctation Fixes: ``` Deprecation triggered by Composer\Test\Installer\LibraryInstallerTest::testUninstall: strpos(): Passing null to parameter composer#1 ($haystack) of type string is deprecated Stack trace: #0 [internal function]: Symfony\Bridge\PhpUnit\DeprecationErrorHandler->handleError(8192, '...', '...', 202) composer#1 src/Composer/Installer/LibraryInstaller.php(202): strpos(NULL, '...') composer#2 vendor/react/promise/src/FulfilledPromise.php(28): Composer\Installer\LibraryInstaller->Composer\Installer\{closure}(NULL) composer#3 src/Composer/Installer/LibraryInstaller.php(208): React\Promise\FulfilledPromise->then(Object(Closure)) composer#4 tests/Composer/Test/Installer/LibraryInstallerTest.php(221): Composer\Installer\LibraryInstaller->uninstall(Object(Mock_InstalledRepositoryInterface_e3699f95), Object(Mock_Package_e4571076)) ... ```

) * PHP 8.1/Tests: fix some deprecation warnings The default value for the `preg_split()` `$limit` parameter is `-1`, not `null`. Fixes numerous `preg_split(): Passing null to parameter #3 ($limit) of type int is deprecated` notices when running the test suite. Ref: https://www.php.net/manual/en/function.preg-split.php * PHP 8.1/NoProxyPattern: fix deprecation warning The default value for the `preg_split()` `$limit` parameter is `-1`, not `null`. Fixes some `preg_split(): Passing null to parameter #3 ($limit) of type int is deprecated` notices when running the test suite. ``` Deprecation triggered by Composer\Test\Util\Http\ProxyManagerTest::testGetProxyForRequest: preg_split(): Passing null to parameter #3 ($limit) of type int is deprecated Stack trace: 0 [internal function]: Symfony\Bridge\PhpUnit\DeprecationErrorHandler->handleError(8192, '...', '...', 42) 1 src/Composer/Util/NoProxyPattern.php(42): preg_split('...', '...', NULL, 1) 2 src/Composer/Util/Http/ProxyManager.php(148): Composer\Util\NoProxyPattern->__construct('...') 3 src/Composer/Util/Http/ProxyManager.php(50): Composer\Util\Http\ProxyManager->initProxyData() 4 src/Composer/Util/Http/ProxyManager.php(59): Composer\Util\Http\ProxyManager->__construct() 5 tests/Composer/Test/Util/Http/ProxyManagerTest.php(75): Composer\Util\Http\ProxyManager::getInstance() ... ``` Ref: https://www.php.net/manual/en/function.preg-split.php * PHP 8.1: fix deprecation warnings / http_build_query() This fixes all relevant calls to the PHP native `http_build_query()` function. The second parameter of which is the _optional_ `$numeric_prefix` parameter which expects a `string`. A parameter being optional, however, does not automatically make it nullable. As of PHP 8.1, passing `null` to a non-nullable PHP native function will generate a deprecation notice. In this case, these function calls yielded a `http_build_query(): Passing null to parameter #2 ($numeric_prefix) of type string is deprecated` notice. Changing the `null` to an empty string fixes this without BC-break. Fixes a few deprecation warnings found when running the tests. Refs: * https://www.php.net/manual/en/function.http-build-query.php * https://wiki.php.net/rfc/deprecate_null_to_scalar_internal_arg * PHP 8.1: fix deprecation notices / PharData::__construct() This fixes all relevant calls to the PHP native `PharData::__construct()` method. The second parameter of this method is the _optional_ `$flags` parameter which expects an `int` of flags to be passed to the `Phar` parent class `RecursiveDirectoryIterator`. Fixed by passing the default value for the `$flags` parameter as per the `RecursiveDirectoryIterator::__construct()` method. The third parameter of the method is the _optional_ `$alias` parameter which expects an `string`. Fixed by passing an empty string. Fixes various notices along the lines of: ``` Deprecation triggered by Composer\Test\Package\Archiver\ArchiveManagerTest::testArchiveTar: PharData::__construct(): Passing null to parameter #2 ($flags) of type int is deprecated Stack trace: 0 [internal function]: Symfony\Bridge\PhpUnit\DeprecationErrorHandler->handleError(8192, '...', '...', 55) 1 src/Composer/Package/Archiver/PharArchiver.php(55): PharData->__construct('...', NULL, NULL, 2) 2 src/Composer/Package/Archiver/ArchiveManager.php(193): Composer\Package\Archiver\PharArchiver->archive('...', '...', '...', Array, false) 3 tests/Composer/Test/Package/Archiver/ArchiveManagerTest.php(65): Composer\Package\Archiver\ArchiveManager->archive(Object(Composer\Package\CompletePackage), '...', '...') ... ``` Refs: * https://www.php.net/manual/en/phardata.construct.php * https://www.php.net/manual/en/recursivedirectoryiterator.construct.php Co-authored-by: jrfnl <[email protected]>

beberlei and others added 4 commits June 8, 2011 00:14

Rewrite PearRepository to implement PEAR Client/Server protocol itsel…

f120d66

…f, taking longer then pear remote-list, but at least showing ALL available versions, making arbitrary dependencies possible.

Merge git://github.com/beberlei/composer

6877c5f

Using copy function.

5a60c95

Seldaek closed this Jun 28, 2011

igorw pushed a commit to igorw/composer that referenced this pull request Mar 25, 2012

Merge pull request composer#3 from toastedghost/svn-auth-reloaded-imp

af8d421

Improve 'getTags()' and 'getBranches()'

davidwindell mentioned this pull request May 17, 2012

Undefined variable: pipes #709

Closed

cevou mentioned this pull request Sep 20, 2012

Wrong command "mode" #1129

Closed

ausprog mentioned this pull request Oct 14, 2012

Cannot Install or Update (First time) - 'mode' not recognised as well as Fatal and Stack trace errors #1208

Closed

kingcrunch mentioned this pull request Dec 20, 2012

ErrorException: proc_open(): fork failed - Cannot allocate memory in phar #945

Closed

kimdcottrell mentioned this pull request Apr 30, 2013

Uncaught exception 'ErrorException' with message 'proc_open(): fork failed - Cannot allocate memory' #1849

Closed

nicktacular mentioned this pull request Jul 25, 2013

update causes different hash on windows #2115

Closed

ericbae mentioned this pull request Aug 8, 2013

Composer update gives "cannot allocate memory" error. #2160

Closed

digitalkaoz pushed a commit to digitalkaoz/composer that referenced this pull request Nov 22, 2013

Merge pull request composer#3 from toastedghost/svn-auth-reloaded-imp

7292a79

Improve 'getTags()' and 'getBranches()'

digitalkaoz pushed a commit to digitalkaoz/composer that referenced this pull request Nov 22, 2013

Update should-i-commit-the-dependencies-in-my-vendor-directory.md

0d6dd3c

Tweak option composer#3 for including dependencies in a GIT repo.

thmsklngr mentioned this pull request Jan 9, 2014

Can't deactivate composer anymore #2570

Closed

sachinjadhav21 mentioned this pull request Mar 17, 2014

Install Fails on Windows with error "not within the allowed path" #2636

Closed

Seldaek pushed a commit that referenced this pull request Mar 26, 2014

Merge pull request #3 from clarkstuth/master

bdd225a

Fixing perforce driver/downloader bugs

anjorinjnr mentioned this pull request Dec 29, 2014

Uncaught exception 'ErrorException' with message 'proc_open(): fork failed - Cannot allocate memory' #3600

Closed

romeox6x66 mentioned this pull request Jun 7, 2015

ssl #4116

Closed

mauriciopiber mentioned this pull request Mar 15, 2016

Composer waiting too long on Post-Install and returning Fork Exception. #5063

Closed

donutloop mentioned this pull request Jun 21, 2016

There is no version of Composer available for your PHP version (7.0.99-hhvm) #5449

Closed

ducktype mentioned this pull request Nov 11, 2016

run Composer from php script #1906

Closed

spekary mentioned this pull request Jun 21, 2017

update is installing old version of dev-master #6497

Closed

oaulakh mentioned this pull request Oct 30, 2017

whenever i try to use composer i get this source error #6773

Closed

thepedroferrari mentioned this pull request Jan 5, 2018

Autoload issues in 1.6.1 #6977

Closed

greg-1-anderson mentioned this pull request Apr 9, 2018

autoload_files not to loaded on script runs #4764

Closed

gilcierweb mentioned this pull request Apr 28, 2018

Bug Devil Not install ubuntu debian #7290

Closed

ruudk mentioned this pull request Dec 8, 2021

[2.2.0-RC1] AutoloadGenerator.php crashes when overriding a file using autoload.files + autoload.exclude-from-classmap #10344

Closed

ghost mentioned this pull request Dec 31, 2021

composer outdated ou composer update Fatal error: Uncaught TypeError #10408

Closed

palmic mentioned this pull request Jan 17, 2022

[PHP 7.1] Composer 2.2.4 fetched from https://getcomposer.org/composer.phar causes "Call to undefined function stream_isatty()" #10464

Closed

Jaimin-Devhero mentioned this pull request Mar 30, 2022

CI CD pipeline error rtrim expects parameter 1 to be string, bool given #10670

Closed

carlalexander mentioned this pull request Apr 1, 2022

Invalid call to isMatch in RootPackageLoader #10689

Closed

DesRodman mentioned this pull request Aug 24, 2022

Composer\Downloader\TransportException::setResponseInfo() #11019

Closed

ghost mentioned this pull request Sep 24, 2022

Script @php artisan package:discover --ansi handling the post-autoload-dump event returned with error code 255 #10481

Closed

ondrejmirtes mentioned this pull request Sep 4, 2023

ArgumentCountError on "End-of-central-directory signature not found" #11619

Closed

anaskhudur mentioned this pull request Jan 13, 2024

composer audit checks alias instead of actual package version #11771

Closed

newcharmingdev7 mentioned this pull request Oct 25, 2024

How to solve this issue in composer initialization. #12174

Closed

remco-pc mentioned this pull request Dec 4, 2024

composer update failure #12221

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Implement PEAR support. #3

Implement PEAR support. #3

Uh oh!

xaav commented Jun 28, 2011

Uh oh!

Seldaek commented Jun 28, 2011

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Implement PEAR support. #3

Implement PEAR support. #3

Uh oh!

Conversation

xaav commented Jun 28, 2011

Uh oh!

Seldaek commented Jun 28, 2011

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants