Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@xaav
Copy link
Contributor

@xaav xaav commented Jun 28, 2011

Updated contributors link.

Seldaek added a commit that referenced this pull request Jun 28, 2011
Edited README.md via GitHub
@Seldaek Seldaek merged commit f68daef into composer:master Jun 28, 2011
@Seldaek
Copy link
Member

Seldaek commented Jun 28, 2011

Thanks, I'm merging your other PR soon, was doing some changes to it.

digitalkaoz pushed a commit to digitalkaoz/composer that referenced this pull request Nov 22, 2013
Edited README.md via GitHub
Seldaek pushed a commit that referenced this pull request Mar 26, 2014
removing dead code lines and excess comments.   Looks good - @clarkstuth
@romeox6x66 romeox6x66 mentioned this pull request Jun 7, 2015
jrfnl added a commit to jrfnl/composer that referenced this pull request Aug 5, 2021
Discovered while running the existing unit tests on PHP 8.1.

Fixes:
```
Deprecation triggered by Composer\Test\DependencyResolver\PoolBuilderTest::testPoolBuilder:
preg_match(): Passing null to parameter composer#2 ($subject) of type string is deprecated

Stack trace:
#0 [internal function]: Symfony\Bridge\PhpUnit\DeprecationErrorHandler->handleError(8192, '...', '...', 597)
composer#1 src/Composer/Package/Package.php(597): preg_match('...', NULL)
composer#2 src/Composer/DependencyResolver/PoolBuilder.php(360): Composer\Package\Package->setSourceDistReferences('...')
composer#3 src/Composer/DependencyResolver/PoolBuilder.php(338): Composer\DependencyResolver\PoolBuilder->loadPackage(Object(Composer\DependencyResolver\Request), Object(Composer\Package\CompletePackage))
composer#4 src/Composer/DependencyResolver/PoolBuilder.php(195): Composer\DependencyResolver\PoolBuilder->loadPackagesMarkedForLoading(Object(Composer\DependencyResolver\Request), Array)
composer#5 src/Composer/Repository/RepositorySet.php(229): Composer\DependencyResolver\PoolBuilder->buildPool(Array, Object(Composer\DependencyResolver\Request))
composer#6 tests/Composer/Test/DependencyResolver/PoolBuilderTest.php(110): Composer\Repository\RepositorySet->createPool(Object(Composer\DependencyResolver\Request), Object(Composer\IO\NullIO))
...
```
jrfnl added a commit to jrfnl/composer that referenced this pull request Aug 5, 2021
Discovered while running the existing unit tests on PHP 8.1.

Fixes:
```
Deprecation triggered by Composer\Test\DependencyResolver\PoolBuilderTest::testPoolBuilder:
preg_match(): Passing null to parameter composer#2 ($subject) of type string is deprecated

Stack trace:
#0 [internal function]: Symfony\Bridge\PhpUnit\DeprecationErrorHandler->handleError(8192, '...', '...', 597)
composer#1 src/Composer/Package/Package.php(597): preg_match('...', NULL)
composer#2 src/Composer/DependencyResolver/PoolBuilder.php(360): Composer\Package\Package->setSourceDistReferences('...')
composer#3 src/Composer/DependencyResolver/PoolBuilder.php(338): Composer\DependencyResolver\PoolBuilder->loadPackage(Object(Composer\DependencyResolver\Request), Object(Composer\Package\CompletePackage))
composer#4 src/Composer/DependencyResolver/PoolBuilder.php(195): Composer\DependencyResolver\PoolBuilder->loadPackagesMarkedForLoading(Object(Composer\DependencyResolver\Request), Array)
composer#5 src/Composer/Repository/RepositorySet.php(229): Composer\DependencyResolver\PoolBuilder->buildPool(Array, Object(Composer\DependencyResolver\Request))
composer#6 tests/Composer/Test/DependencyResolver/PoolBuilderTest.php(110): Composer\Repository\RepositorySet->createPool(Object(Composer\DependencyResolver\Request), Object(Composer\IO\NullIO))
...
```
jrfnl added a commit to jrfnl/composer that referenced this pull request Aug 5, 2021
Discovered while running the existing unit tests on PHP 8.1.

Fixes:
```
Deprecation triggered by Composer\Test\Downloader\FossilDownloaderTest::testUpdate:
trim(): Passing null to parameter composer#1 ($string) of type string is deprecated

Stack trace:
#0 [internal function]: Symfony\Bridge\PhpUnit\DeprecationErrorHandler->handleError(8192, '...', '...', 93)
composer#1 src/Composer/Downloader/FossilDownloader.php(93): trim(NULL)
composer#2 src/Composer/Downloader/VcsDownloader.php(267): Composer\Downloader\FossilDownloader->getLocalChanges(Object(Mock_PackageInterface_c17fec12), '...')
composer#3 src/Composer/Downloader/VcsDownloader.php(99): Composer\Downloader\VcsDownloader->cleanChanges(Object(Mock_PackageInterface_c17fec12), '...', true)
composer#4 tests/Composer/Test/Downloader/FossilDownloaderTest.php(143): Composer\Downloader\VcsDownloader->prepare('...', Object(Mock_PackageInterface_c17fec12), '...', Object(Mock_PackageInterface_c17fec12))
...
```
jrfnl added a commit to jrfnl/composer that referenced this pull request Aug 5, 2021
The default value for the `ProcessExecutor::$errorOutput` property is `null`, so the return value of `$this->process->getErrorOutput()` could well be `null`.

In that case, we may as well bypass the whole `foreach` as it will never match any of the recognized authentication failure messages.

Fixes:
```
Deprecation triggered by Composer\Test\Downloader\GitDownloaderTest::testDownloadThrowsRuntimeExceptionIfGitCommandFails:
strpos(): Passing null to parameter composer#1 ($haystack) of type string is deprecated

Stack trace:
#0 [internal function]: Symfony\Bridge\PhpUnit\DeprecationErrorHandler->handleError(8192, '...', '...', 340)
composer#1 src/Composer/Util/Git.php(340): strpos(NULL, '...')
composer#2 src/Composer/Util/Git.php(200): Composer\Util\Git->isAuthenticationFailure('...', Array)
composer#3 src/Composer/Downloader/GitDownloader.php(121): Composer\Util\Git->runCommand(Object(Closure), '...', NULL, true)
composer#4 src/Composer/Downloader/VcsDownloader.php(137): Composer\Downloader\GitDownloader->doInstall(Object(Mock_PackageInterface_f8be9ebd), '...', '...')
composer#5 tests/Composer/Test/Downloader/GitDownloaderTest.php(349): Composer\Downloader\VcsDownloader->install(Object(Mock_PackageInterface_f8be9ebd), '...')
...
```
jrfnl added a commit to jrfnl/composer that referenced this pull request Aug 5, 2021
The default value for the `ProcessExecutor::$errorOutput` property is `null`, so the return value of `$this->process->getErrorOutput()` could well be `null`.

In that case, we may as well bypass the whole `foreach` as it will never match any of the recognized authentication failure messages.

Fixes:
```
Deprecation triggered by Composer\Test\Downloader\GitDownloaderTest::testDownloadThrowsRuntimeExceptionIfGitCommandFails:
strpos(): Passing null to parameter composer#1 ($haystack) of type string is deprecated

Stack trace:
#0 [internal function]: Symfony\Bridge\PhpUnit\DeprecationErrorHandler->handleError(8192, '...', '...', 340)
composer#1 src/Composer/Util/Git.php(340): strpos(NULL, '...')
composer#2 src/Composer/Util/Git.php(200): Composer\Util\Git->isAuthenticationFailure('...', Array)
composer#3 src/Composer/Downloader/GitDownloader.php(121): Composer\Util\Git->runCommand(Object(Closure), '...', NULL, true)
composer#4 src/Composer/Downloader/VcsDownloader.php(137): Composer\Downloader\GitDownloader->doInstall(Object(Mock_PackageInterface_f8be9ebd), '...', '...')
composer#5 tests/Composer/Test/Downloader/GitDownloaderTest.php(349): Composer\Downloader\VcsDownloader->install(Object(Mock_PackageInterface_f8be9ebd), '...')
...
```
jrfnl added a commit to jrfnl/composer that referenced this pull request Aug 5, 2021
Fixes:
```
Deprecation triggered by Composer\Test\Installer\LibraryInstallerTest::testUninstall:
strpos(): Passing null to parameter composer#1 ($haystack) of type string is deprecated

Stack trace:
#0 [internal function]: Symfony\Bridge\PhpUnit\DeprecationErrorHandler->handleError(8192, '...', '...', 202)
composer#1 src/Composer/Installer/LibraryInstaller.php(202): strpos(NULL, '...')
composer#2 vendor/react/promise/src/FulfilledPromise.php(28): Composer\Installer\LibraryInstaller->Composer\Installer\{closure}(NULL)
composer#3 src/Composer/Installer/LibraryInstaller.php(208): React\Promise\FulfilledPromise->then(Object(Closure))
composer#4 tests/Composer/Test/Installer/LibraryInstallerTest.php(221): Composer\Installer\LibraryInstaller->uninstall(Object(Mock_InstalledRepositoryInterface_e3699f95), Object(Mock_Package_e4571076))
...
```
jrfnl added a commit to jrfnl/composer that referenced this pull request Aug 5, 2021
…ctation

Fixes:
```
Deprecation triggered by Composer\Test\Installer\LibraryInstallerTest::testUninstall:
strpos(): Passing null to parameter composer#1 ($haystack) of type string is deprecated

Stack trace:
#0 [internal function]: Symfony\Bridge\PhpUnit\DeprecationErrorHandler->handleError(8192, '...', '...', 202)
composer#1 src/Composer/Installer/LibraryInstaller.php(202): strpos(NULL, '...')
composer#2 vendor/react/promise/src/FulfilledPromise.php(28): Composer\Installer\LibraryInstaller->Composer\Installer\{closure}(NULL)
composer#3 src/Composer/Installer/LibraryInstaller.php(208): React\Promise\FulfilledPromise->then(Object(Closure))
composer#4 tests/Composer/Test/Installer/LibraryInstallerTest.php(221): Composer\Installer\LibraryInstaller->uninstall(Object(Mock_InstalledRepositoryInterface_e3699f95), Object(Mock_Package_e4571076))
...
```
@jrfnl jrfnl mentioned this pull request Aug 19, 2021
herndlm added a commit to herndlm/composer that referenced this pull request Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants