Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: settings dir with deduplicated copier subdir #2071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Apr 17, 2025
Merged

fix: settings dir with deduplicated copier subdir #2071

merged 11 commits into from
Apr 17, 2025

Conversation

@roteiro
Copy link
Contributor

@roteiro roteiro commented Apr 4, 2025

platformdirs implicitely sets appauthor to appname if not explicitely set to false, resulting in an dir with <CONFIG_ROOT>/copier/copier

Closes #2070

@roteiro
fix: settings dir with deduplicated copier subdir
818f73d 
platformdirs implicitely sets appauthor to appname if not explicitely set to false, resulting in an dir with <CONFIG_ROOT>/copier/copier
pawamoy
pawamoy reviewed Apr 4, 2025
View reviewed changes
Copy link
Contributor

@pawamoy pawamoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Could you add a test (that only runs on Windows of course)?

sisp
sisp reviewed Apr 4, 2025
View reviewed changes
pawamoy
pawamoy approved these changes Apr 15, 2025
View reviewed changes
Copy link
Contributor

@pawamoy pawamoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the update 🙂

sisp
sisp requested changes Apr 15, 2025
View reviewed changes
sisp
sisp reviewed Apr 16, 2025
View reviewed changes
@roteiro
Copy link
Contributor Author

roteiro commented Apr 16, 2025

@sisp ok, should be ready for review now. The added test and mypy passed locally. There were some failures on the test suite but they seem unrelated to my changes?
Please also have a look if I got the staticmethod right, I'm not that experienced with OOP.
I added a short note in the documentation about the deprecation of the old settings path, please check if that is necessary or can be removed

sisp
sisp requested changes Apr 17, 2025
View reviewed changes
Copy link
Member

@sisp sisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉 Just some minor remarks, and Ruff and Prettier will want to reformat a little, but we can leave this to the autofix action.

roteiro and others added 2 commits April 17, 2025 12:15
@roteiro @sisp
fix: remove superfluous import
c2f7b56 
Co-authored-by: Sigurd Spieckermann <[email protected]>
@roteiro @sisp
docs: fix grammar error
18fa842 
Co-authored-by: Sigurd Spieckermann <[email protected]>
@roteiro
Copy link
Contributor Author

roteiro commented Apr 17, 2025 •
edited
Loading

LGTM! 🎉 Just some minor remarks, and Ruff and Prettier will want to reformat a little, but we can leave this to the autofix action.

Thanks for the guidance, I quite learned something with this small contribution. I assume you will merge with a proper commit message for the changelog generation?

@roteiro roteiro requested a review from sisp April 17, 2025 19:17
@codecov
Copy link

codecov bot commented Apr 17, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 62.50000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 97.91%. Comparing base (b078959) to head (f1ae9c7).
Report is 124 commits behind head on master.

Files with missing lines Patch % Lines
copier/settings.py 60.00% 4 Missing ⚠️
tests/test_settings.py 66.66% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2071      +/-   ##
==========================================
- Coverage   98.14%   97.91%   -0.24%     
==========================================
  Files          54       54              
  Lines        5881     5896      +15     
==========================================
+ Hits         5772     5773       +1     
- Misses        109      123      +14
Flag Coverage Δ
unittests 97.91% <62.50%> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sisp
sisp approved these changes Apr 17, 2025
View reviewed changes
Copy link
Member

@sisp sisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉 Thanks for identifying and fixing this bug, @roteiro! 🙏

@sisp sisp merged commit 465a463 into copier-org:master Apr 17, 2025
20 of 22 checks passed
@roteiro roteiro deleted the fix_settings_path branch April 17, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sisp sisp sisp approved these changes

@pawamoy pawamoy pawamoy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Windows11: Location of settings.yml incorrect

3 participants

@roteiro @sisp @pawamoy