Keep golang to 1.24.2 due to build issues in 1.24.3 #7337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR keeep golang to 1.24.2 due to build issues in 1.24.3: golang/go#73617 This happens when make -f Makefile.release release is invoked in coredns. Signed-off-by: Yong Tang <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7337 +/- ##
==========================================
+ Coverage 55.70% 59.49% +3.79%
==========================================
Files 224 273 +49
Lines 10016 17930 +7914
==========================================
+ Hits 5579 10668 +5089
- Misses 3978 6638 +2660
- Partials 459 624 +165 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
thevilledev
approved these changes
May 30, 2025
Collaborator
There was a problem hiding this comment.
LGTM
Side note, Go 1.23.10 and 1.24.4 will be released June 5th. It has three CVE fixes with unknown severity at this point. We might need to make a new release then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Why is this pull request needed and what does it do?
This PR keeep golang to 1.24.2 due to build issues in 1.24.3:
golang/go#73617
This happens when make -f Makefile.release release is invoked in coredns.
go: downloading github.com/josharian/intern v1.0.0
go: downloading github.com/ryanuber/go-glob v1.0.0
github.com/coredns/coredns
link: duplicated definition of symbol dlopen, from github.com/ebitengine/purego and github.com/ebitengine/purego
make[1]: *** [Makefile:20: coredns] Error 1
make[1]: Leaving directory '/go/src/github.com/coredns/coredns'
make: *** [Makefile.release:71: build] Error 2
2. Which issues (if any) are related?
N/A
3. Which documentation changes (if any) need to be made?
N/A
4. Does this introduce a backward incompatible change or deprecation?
N/A