Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@SuperQ
Copy link
Collaborator

@SuperQ SuperQ commented Jun 5, 2025

1. Why is this pull request needed and what does it do?

  • Update Go build to 1.24.4.
  • Add comment about supported Go versions.
  • Update README about minimum supported version.
  • Bump github.com/DataDog/go-sqllexer: retracted by module author: This version had memory leaks and should not be used

2. Which issues (if any) are related?

3. Which documentation changes (if any) need to be made?

4. Does this introduce a backward incompatible change or deprecation?

@thevilledev
Copy link
Collaborator

Had to be reverted to 1.24.2 in #7337

@SuperQ
Copy link
Collaborator Author

SuperQ commented Jun 5, 2025

Oh, good to know, I'll update this when 1.24.4 is released.

@thevilledev
Copy link
Collaborator

I believe the fix for the 1.24.3 build issue is in 1.24.4 which will be released today. Can we try that version in this PR?

* Update Go build to 1.24.4.
* Add comment about supported Go versions.
* Update README about minimum supported version.
* Bump github.com/DataDog/go-sqllexer: retracted by module author: This version had memory leaks and should not be used

Signed-off-by: SuperQ <[email protected]>
@SuperQ SuperQ force-pushed the superq/go-sqllexer branch from b65b31f to b4ed28b Compare June 5, 2025 21:23
@yongtang yongtang merged commit 0eb5542 into master Jun 5, 2025
16 checks passed
@yongtang yongtang deleted the superq/go-sqllexer branch June 5, 2025 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants