-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Closed
Labels
help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Description
This was intentional, but it is not optimal.
For 1.21.0, we changed the crio config command to only print fields that are different than the default. This allows config migration to be easier, and config changes as well.
However, now running make install.config (which all packaged solutions do, as well as our recommendation for installation from source) installs an empty file--it's all the default!
This is sub-par--often users want to use the default config as a way to see the available options.
I take the blame for this one, I guided the solution to #4506 without checking the reprocussions and making sure all stakeholders were okay with the fix.
The good news is: we have another good first issue!
Here are three proposed pieces:
crio configshould print all the fields, with the default ones commented out, instead of omitted. This will be used to populate the default configurationcrio config --allshould print all the fields, with both default and non-default commented outcrio config --verboseshould print only the non-default fields. This will be used for generating drop-in files
Exagone313
Metadata
Metadata
Assignees
Labels
help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.