Automatically label containers running systemd with the correct label #3754
Conversation
Newer versions of container-selinux, container-selinux-2.132.0 or newer, supply a `container_init_t` label. If CRI-O is running systemd or init inside of the container, then the container will require different SELinux privs to run the container. By using the new SELinux label, we can run ordinary containers with a tighter selinux policy then those running the init system, makeing the overlay system more secure. The eliminates the need to turn on the container_manage_cgroup SELinux boolean. Ie no need to execute ``` setsebool -P container_manage_cgroup 1 ``` Any longer. On systems without the updated container-selnux package, the containers will still attempt to run the standard container type `container_t`, and still require the boolean. Signed-off-by: Daniel J Walsh <[email protected]>
Signed-off-by: Peter Hunt <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
taking over #3707 |
|
LGTM |
|
/lgtm |
|
/cherry-pick release-1.18 |
|
@umohnani8: failed to push cherry-picked changes in GitHub: pushing failed, output: "To https://github.com/openshift-cherrypick-robot/cri-o\n ! [remote rejected] cherry-pick-3754-to-release-1.18 -> cherry-pick-3754-to-release-1.18 (cannot lock ref 'refs/heads/cherry-pick-3754-to-release-1.18': reference already exists)\nerror: failed to push some refs to 'https://openshift-cherrypick-robot:[email protected]/openshift-cherrypick-robot/cri-o'\n", error: exit status 1 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@umohnani8: new pull request created: #3764 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind Feature
Newer versions of container-selinux, container-selinux-2.132.0 or newer,
supply a
container_init_tlabel. If CRI-O is running systemd or init insideof the container, then the container will require different SELinux privs
to run the container.
By using the new SELinux label, we can run ordinary containers with a tighter
selinux policy then those running the init system, makeing the overlay system
more secure.
The eliminates the need to turn on the container_manage_cgroup SELinux boolean.
Ie. no need to execute
Any longer. On systems without the updated container-selnux package, the containers will still
attempt to run the standard container type
container_t, and still require the boolean.Signed-off-by: Daniel J Walsh [email protected]
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?