[release-1.18] Automatically label containers running systemd with the correct label #3764
+50
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer versions of container-selinux, container-selinux-2.132.0 or newer, supply a `container_init_t` label. If CRI-O is running systemd or init inside of the container, then the container will require different SELinux privs to run the container. By using the new SELinux label, we can run ordinary containers with a tighter selinux policy then those running the init system, makeing the overlay system more secure. The eliminates the need to turn on the container_manage_cgroup SELinux boolean. Ie no need to execute ``` setsebool -P container_manage_cgroup 1 ``` Any longer. On systems without the updated container-selnux package, the containers will still attempt to run the standard container type `container_t`, and still require the boolean. Signed-off-by: Daniel J Walsh <[email protected]>
Signed-off-by: Peter Hunt <[email protected]>
Member
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: openshift-cherrypick-robot, umohnani8 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## release-1.18 #3764 +/- ##
================================================
- Coverage 40.53% 40.51% -0.02%
================================================
Files 105 105
Lines 8608 8611 +3
================================================
Hits 3489 3489
- Misses 4808 4811 +3
Partials 311 311 |
Member
|
Replacing with #3765 to fix the vendor failures. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #3754
/assign umohnani8