Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@umohnani8
Copy link
Member

This reverts commit a1bd010.
Reverting the e2e-aws work as we want to add this to master now and we automatically forward all master PRs to 1.19. So reverting to avoid merge conflicts once #3895 is merged.

@umohnani8 umohnani8 requested review from mrunalp and runcom as code owners June 19, 2020 15:33
@openshift-ci-robot openshift-ci-robot added the dco-signoff: no Indicates the PR's author has not DCO signed all their commits. label Jun 19, 2020
This reverts commit a1bd010.

Signed-off-by: Urvashi Mohnani <[email protected]>
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: umohnani8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: umohnani8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2020
@openshift-ci-robot openshift-ci-robot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Jun 19, 2020
@umohnani8
Copy link
Member Author

@mrunalp @haircommander PTAL.
We are going to have to force merge this as e2e-aws and launch-aws will fail.

@codecov
Copy link

codecov bot commented Jun 19, 2020

Codecov Report

Merging #3896 into release-1.19 will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           release-1.19    #3896   +/-   ##
=============================================
  Coverage         40.58%   40.58%           
=============================================
  Files               109      109           
  Lines              8812     8812           
=============================================
  Hits               3576     3576           
  Misses             4914     4914           
  Partials            322      322           

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 19, 2020

@umohnani8: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/launch-aws 4e73ba3 link /test launch-aws
ci/prow/images 4e73ba3 link /test images
ci/prow/e2e-aws 4e73ba3 link /test e2e-aws
ci/openshift-jenkins/integration_fedora 4e73ba3 link /test integration_fedora
ci/openshift-jenkins/integration_rhel 4e73ba3 link /test integration_rhel
ci/openshift-jenkins/e2e_fedora 4e73ba3 link /test e2e_fedora
ci/openshift-jenkins/e2e_crun 4e73ba3 link /test e2e_crun
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@haircommander
Copy link
Member

+1 on the force merge lgtm

@umohnani8
Copy link
Member Author

Force merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants