managed_ns: deflake tests #3839
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
c195228 to
cca77de
Compare
Codecov Report
@@ Coverage Diff @@
## master #3839 +/- ##
==========================================
+ Coverage 40.19% 40.20% +0.01%
==========================================
Files 105 105
Lines 8748 8748
==========================================
+ Hits 3516 3517 +1
+ Misses 4911 4910 -1
Partials 321 321 |
turns out, the PID 42 (as idiomatic a test variable it is) is not the best PID to use. NamespacePaths() returns /proc entries if the PID is running, so sometimes there was a PID 42 on the system, and the tests returned valid paths, causing the test to fail This PR updates the tests to use the values 0 (unset pid), 1 (running pid), and 4194305 (never running pid, as it's max_pid+1) it also fixes a small inconsistency in reserving space for the slice of namespace paths Signed-off-by: Peter Hunt <[email protected]>
cca77de to
fa61142
Compare
|
/retest |
1 similar comment
|
/retest |
|
/test e2e_crun |
|
/retest |
|
PTAL @umohnani8 @mrunalp |
|
/lgtm |
|
/cherry-pick release-1.18 |
|
@haircommander: failed to push cherry-picked changes in GitHub: pushing failed, output: "To https://github.com/openshift-cherrypick-robot/cri-o\n ! [remote rejected] cherry-pick-3839-to-release-1.18 -> cherry-pick-3839-to-release-1.18 (cannot lock ref 'refs/heads/cherry-pick-3839-to-release-1.18': reference already exists)\nerror: failed to push some refs to 'https://openshift-cherrypick-robot:[email protected]/openshift-cherrypick-robot/cri-o'\n", error: exit status 1 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@haircommander: new pull request created: #3847 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind flake
What this PR does / why we need it:
turns out, the PID 42 (as idiomatic a test variable it is) is not the best PID to use.
NamespacePaths() returns /proc entries if the PID is running, so sometimes there was a PID 42 on the system, and the tests returned valid paths, causing the test to fail
This PR updates the tests to use the values 0 (unset pid), 1 (running pid), and 4194305 (never running pid, as it's max_pid+1)
it also fixes a small inconsistency in reserving space for the slice of namespace paths
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?