[1.19] Add logic for running openshift e2e-aws tests #3832
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: umohnani8 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: umohnani8 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@mrunalp @haircommander PTAL |
|
other than the shellcheck saddness LGTM |
|
@umohnani8 Looks like the shell scripts being added are copied over from OpenShift? I am okay if we skip running shellcheck on those. |
|
@mrunalp yeah they are. |
|
/retest |
Codecov Report
@@ Coverage Diff @@
## release-1.19 #3832 +/- ##
=============================================
Coverage 40.18% 40.18%
=============================================
Files 105 105
Lines 8692 8692
=============================================
Hits 3493 3493
Misses 4888 4888
Partials 311 311 |
Signed-off-by: Urvashi Mohnani <[email protected]>
|
unit test flake fixed here |
|
/lgtm |
|
/cherry-pick master |
|
@umohnani8: failed to push cherry-picked changes in GitHub: pushing failed, output: "To https://github.com/openshift-cherrypick-robot/cri-o\n ! [remote rejected] cherry-pick-3832-to-master -> cherry-pick-3832-to-master (cannot lock ref 'refs/heads/cherry-pick-3832-to-master': reference already exists)\nerror: failed to push some refs to 'https://openshift-cherrypick-robot:[email protected]/openshift-cherrypick-robot/cri-o'\n", error: exit status 1 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@umohnani8: new pull request created: #3895 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Urvashi Mohnani [email protected]
What type of PR is this?
/kind failing-test
Not a failing test, but adding a new test.
What this PR does / why we need it:
Add the various specfile and Dockerfile needed to run the e2e-aws tests on PRs in the release-1.19 branch.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?