Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[master] Revert "container_server: disable fdatasync() for atomic writes" #3975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mrunalp merged 1 commit into from
Aug 17, 2020
Merged

[master] Revert "container_server: disable fdatasync() for atomic writes" #3975

mrunalp merged 1 commit into from
Aug 17, 2020
+0 −4

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Jul 17, 2020

This is an automated cherry-pick of #3972

/assign mrunalp

Fix a bug where a sudden reboot causes incomplete image writes. This could cause image storage to be corrupted, resulting in an error `layer not known`.

@openshift-ci-robot openshift-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jul 17, 2020
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 17, 2020
Merged
@mrunalp mrunalp changed the title [master] [1.18] Revert "container_server: disable fdatasync() for atomic writes" [master] Revert "container_server: disable fdatasync() for atomic writes" Jul 17, 2020
@mrunalp
Copy link
Member

mrunalp commented Jul 17, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 17, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2020
@mrunalp
Copy link
Member

mrunalp commented Jul 17, 2020

/test e2e_features_fedora

@codecov
Copy link

codecov bot commented Jul 17, 2020

Codecov Report

Merging #3975 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3975   +/-   ##
=======================================
  Coverage   40.64%   40.64%           
=======================================
  Files         109      109           
  Lines        8839     8839           
=======================================
  Hits         3593     3593           
  Misses       4917     4917           
  Partials      329      329

@giuseppe
Copy link
Member

giuseppe commented Jul 20, 2020

@mrunalp do we want also to revert this on master?

@saschagrunert
Copy link
Member

saschagrunert commented Jul 21, 2020

/retest

@giuseppe
Copy link
Member

giuseppe commented Jul 21, 2020

/hold

I think we don't need to revert this patch once we have the backport for: #3984

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 21, 2020
@mrunalp
Copy link
Member

mrunalp commented Aug 5, 2020

/retest

@giuseppe
Copy link
Member

giuseppe commented Aug 5, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 5, 2020
@sjenning
Copy link

sjenning commented Aug 10, 2020

/retest

1 similar comment
@giuseppe
Copy link
Member

giuseppe commented Aug 11, 2020

/retest

@sjenning
Copy link

sjenning commented Aug 12, 2020

/test integration_rhel

@giuseppe
Copy link
Member

giuseppe commented Aug 12, 2020

/retest

2 similar comments
@giuseppe
Copy link
Member

giuseppe commented Aug 13, 2020

/retest

@giuseppe
Copy link
Member

giuseppe commented Aug 14, 2020

/retest

@saschagrunert
Copy link
Member

saschagrunert commented Aug 14, 2020

/retest

6 similar comments
@giuseppe
Copy link
Member

giuseppe commented Aug 14, 2020

/retest

@giuseppe
Copy link
Member

giuseppe commented Aug 14, 2020

/retest

@giuseppe
Copy link
Member

giuseppe commented Aug 16, 2020

/retest

@giuseppe
Copy link
Member

giuseppe commented Aug 16, 2020

/retest

@giuseppe
Copy link
Member

giuseppe commented Aug 17, 2020

/retest

@giuseppe
Copy link
Member

giuseppe commented Aug 17, 2020

/retest

@giuseppe
Copy link
Member

giuseppe commented Aug 17, 2020

@mrunalp can we just merge? :-)

@TomSweeneyRedHat
Copy link
Contributor

TomSweeneyRedHat commented Aug 17, 2020

LGTM
and happy green test buttons.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 17, 2020

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws 1f51d6d link /test e2e-aws
ci/openshift-jenkins/e2e_crun_cgroupv2 1f51d6d link /test e2e_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mrunalp mrunalp merged commit 8f8bb8f into cri-o:master Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp mrunalp approved these changes

@runcom runcom Awaiting requested review from runcom

@sameo sameo Awaiting requested review from sameo

@sboeuf sboeuf Awaiting requested review from sboeuf

Assignees

@mrunalp mrunalp

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@openshift-cherrypick-robot @mrunalp @openshift-ci-robot @giuseppe @saschagrunert @sjenning @TomSweeneyRedHat