crio wipe: ensure a clean shutdown #3999
Conversation
| **--cgroup-manager**="": cgroup manager (cgroupfs or systemd) (default: systemd) | ||
|
|
||
| **--clean-shutdown-file**="": Location for CRI-O to lay down the clean shutdown file. It indicates whether we've had time to sync changes to disk before shutting down. If not found, crio wipe will clear the storage directory (default: /var/lib/crio/clean.shutdown) | ||
|
|
| }, | ||
| &cli.StringFlag{ | ||
| Name: "clean-shutdown-file", | ||
| Usage: "Location for CRI-O to lay down the clean shutdown file. It indicates whether we've had time to sync changes to disk before shutting down. If not found, crio wipe will clear the storage directory", |
There was a problem hiding this comment.
The verbiage is awesome, but is it too long for the usage? I'd a vague memory that we wanted (required?) these to be under 80 chars.
|
LGTM, one question |
Codecov Report
@@ Coverage Diff @@
## master #3999 +/- ##
==========================================
- Coverage 40.44% 40.36% -0.09%
==========================================
Files 115 115
Lines 9385 9414 +29
==========================================
+ Hits 3796 3800 +4
- Misses 5161 5182 +21
- Partials 428 432 +4 |
|
/test kata-containers |
91bf337 to
a37ca50
Compare
|
/retest |
a37ca50 to
3da2a60
Compare
|
/retest |
|
/retest |
|
@haircommander: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
3da2a60 to
2867c86
Compare
2867c86 to
9842d03
Compare
|
/retest |
3e32581 to
d6659c0
Compare
|
/retest |
d6659c0 to
df07f71
Compare
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, haircommander, mrunalp, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@haircommander a merge conflict :( |
df07f71 to
0d32af4
Compare
|
/retest |
there are cases where crio doesn't get the chance to sync before shutdown. In these cases, container storage can be corrupted. We need to protect against this case by wiping all of storage if we detect we didn't cleanly shutdown. Add an option to specify a clean_shutdown_file that crio will create upon syncing at shutdown Add an option to crio-wipe to clear all of storage if that file is not present Add integration tests to verify Signed-off-by: Peter Hunt <[email protected]>
0d32af4 to
f48f90d
Compare
|
/retest |
1 similar comment
|
/retest |
|
@haircommander: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
there are cases where crio doesn't get the chance to sync before shutdown.
In these cases, container storage can be corrupted.
We need to protect against this case by wiping all of storage if we detect we didn't cleanly shutdown.
Add an option to specify a clean_shutdown_file that crio will create upon syncing at shutdown
Add an option to crio-wipe to clear all of storage if that file is not present
Add integration tests to verify
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?