[1.20] introduce clean shutdown handling #5229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there are cases where crio doesn't get the chance to sync before shutdown. In these cases, container storage can be corrupted. We need to protect against this case by wiping all of storage if we detect we didn't cleanly shutdown. Add an option to specify a clean_shutdown_file that crio will create upon syncing at shutdown Add an option to crio-wipe to clear all of storage if that file is not present Add integration tests to verify Signed-off-by: Peter Hunt <[email protected]>
We created the CleanShutdownFile to work around issues where nodes didn't have time to sync changes to disk before rebooting. This caused an unclean reboot. However, for this to be relevant, the node had to actually reboot. If it didn't, we could fail to remove the storage because the containers are still running. In this case, we shouldn't wipe anything. Signed-off-by: Peter Hunt <[email protected]>
or else, we will unconditionally try to remove the whole directory after upgrading from 1.20, rather than pointedly removing crio specific containers Signed-off-by: Peter Hunt <[email protected]>
This showed up when I was grepping a journal for `error:`, and it's not an error. Signed-off-by: Colin Walters <[email protected]>
2686d42 to
4a61d3c
Compare
Member
Author
|
/retest |
Member
|
okay, verified that this is what we have in 1.21. |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, mrunalp The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
cherry-pick of #3999, #4691, #4697 and #5144
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?