Managed NS: update default configuration values #3929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7476a6c to
a83e8c9
Compare
Codecov Report
@@ Coverage Diff @@
## master #3929 +/- ##
==========================================
+ Coverage 40.51% 40.70% +0.18%
==========================================
Files 109 109
Lines 8829 8823 -6
==========================================
+ Hits 3577 3591 +14
+ Misses 4927 4903 -24
- Partials 325 329 +4 |
80aaec6 to
646591f
Compare
docs/crio.conf.5.md
Outdated
|
|
||
| **manage_ns_lifecycle**=false | ||
| **manage_ns_lifecycle**=true | ||
| Determines whether we pin and remove namespaces and manage their lifecycle |
Contributor
There was a problem hiding this comment.
I know it's pre-existing, but missing ending period.
Member
Author
There was a problem hiding this comment.
I was the one that wrote the original anyway 😎
set ManageNSLifecycle to true by default remove deprecated --manage-network-ns-lifecycle flag and config entry Signed-off-by: Peter Hunt <[email protected]>
there are situations in which we need to restore a stopped pod. specifically, if the node was rebooted, but the kubelet didn't delete the container, then the pod will be stopped and will need to be garbage collected if we remove the namespaces on a stop call, the sandboxes will fail to restore, and the sandboxes won't appear in the list of pods for the kubelet to clean up Signed-off-by: Peter Hunt <[email protected]>
646591f to
d8615ec
Compare
Contributor
|
lgtm |
mrunalp
approved these changes
Jul 16, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, mrunalp, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/lgtm |
Member
Author
|
/retest |
Member
Author
|
/test e2e-aws |
Member
Author
|
/retest |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind api-change
What this PR does / why we need it:
This PR does three things:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?