update pause image to 3.5（3.4.1 for multi-arch support and 3.5 for non-root） #4550

pacoxu · 2021-02-08T02:25:39Z

What type of PR is this?

/kind dependency-change

What this PR does / why we need it:

bumps pause image to 3.5
Per kubernetes/kubernetes#100292

Which issue(s) this PR fixes:

None

part of kubernetes/kubernetes#98205 (changelogs there)

Special notes for your reviewer:

k8s.gcr.io/pause:3.4.1 is for both windows/linux. Details in kubernetes/kubernetes/#98205

https://github.com/containers/common/blob/master/pkg/config/default.go#L48 wait for vendor update?
after update pause image to 3.4.1 and also update the change log kubernetes/kubernetes#98205 merged

Does this PR introduce a user-facing change?

Default pause image is `k8s.gcr.io/pause:3.5`

openshift-ci-robot · 2021-02-08T02:25:47Z

Hi @pacoxu. Thanks for your PR.

I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vendor/github.com/containers/common/pkg/config/containers.conf

pkg/config/config.go

internal/config/migrate/from_1_17.go

pacoxu · 2021-02-14T02:34:13Z

The kubernetes PR is merged.

The pause image in. github.com/containers/common is not used in this project.(wait next release of containers/common)
We may update it later or in this PR. Either is OK.

saschagrunert

/ok-to-test
LGTM

pacoxu · 2021-02-16T15:05:53Z

/retest

pacoxu · 2021-02-19T01:48:54Z

/retest

codecov · 2021-03-19T06:55:35Z

Codecov Report

Merging #4550 (6d25b85) into master (36c46c1) will increase coverage by 1.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4550      +/-   ##
==========================================
+ Coverage   40.21%   41.27%   +1.06%     
==========================================
  Files         115      110       -5     
  Lines        9360     9596     +236     
==========================================
+ Hits         3764     3961     +197     
- Misses       5173     5184      +11     
- Partials      423      451      +28

pacoxu · 2021-03-22T10:45:17Z

/retest

TomSweeneyRedHat · 2021-03-22T14:34:24Z

LGTM

haircommander · 2021-03-22T16:01:37Z

I think this patch will fix the tests:

diff --git a/test/helpers.bash b/test/helpers.bash
index cf3aa199e..b7ad3b449 100644
--- a/test/helpers.bash
+++ b/test/helpers.bash
@@ -84,7 +84,7 @@ POD_IPV6_CIDR_START="1100:2"
 POD_IPV6_DEF_ROUTE="1100:200::1/24"
 
 IMAGES=(
-    k8s.gcr.io/pause:3.2
+    k8s.gcr.io/pause:3.5
     quay.io/crio/busybox:latest
     quay.io/crio/fedora-ping:latest
     quay.io/crio/image-volume-test:latest

pacoxu · 2021-03-29T05:59:06Z

@haircommander Updated
Thanks.

pacoxu · 2021-03-29T08:13:25Z

/test integration_cgroupv2

internal/config/migrate/from_1_17.go

Signed-off-by: pacoxu <[email protected]>

pacoxu · 2021-03-31T03:15:20Z

Updated @TomSweeneyRedHat

saschagrunert

/lgtm

openshift-ci-robot · 2021-03-31T07:25:15Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacoxu, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pacoxu · 2021-03-31T08:17:06Z

/retest

pacoxu · 2021-03-31T08:19:20Z

The cgroup v2 and e2e-gcp failed for other reasons.
/skip
?

openshift-ci · 2021-03-31T09:37:35Z

@pacoxu: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/openshift-jenkins/integration_crun_cgroupv2	`6441ba5`	link	`/test integration_cgroupv2`
ci/openshift-jenkins/e2e_crun_cgroupv2	`6441ba5`	link	`/test e2e_cgroupv2`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

pacoxu requested review from mrunalp and runcom as code owners February 8, 2021 02:25

openshift-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/dependency-change Categorizes issue or PR as related to changing dependencies labels Feb 8, 2021

openshift-ci-robot requested review from kolyshkin and vrothberg February 8, 2021 02:25

openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 8, 2021

pacoxu force-pushed the update/pause-image branch from 866c2e4 to e7f8e75 Compare February 8, 2021 02:27

pacoxu mentioned this pull request Feb 8, 2021

update pause image to 3.4.1 and also update the change log kubernetes/kubernetes#98205

Merged

10 tasks

TBBle reviewed Feb 8, 2021

View reviewed changes

vendor/github.com/containers/common/pkg/config/containers.conf Outdated Show resolved Hide resolved

pacoxu changed the title ~~update pause image to 3.4.1~~ [wip]update pause image to 3.4.1 Feb 8, 2021

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 8, 2021

pacoxu force-pushed the update/pause-image branch from e7f8e75 to c82a207 Compare February 8, 2021 05:03

pacoxu mentioned this pull request Feb 8, 2021

update pause image to 3.4.1 containers/common#445

Merged

saschagrunert reviewed Feb 8, 2021

View reviewed changes

pkg/config/config.go Outdated Show resolved Hide resolved

pacoxu force-pushed the update/pause-image branch from c82a207 to 4c2d12b Compare February 8, 2021 09:48

TBBle reviewed Feb 8, 2021

View reviewed changes

internal/config/migrate/from_1_17.go Show resolved Hide resolved

pacoxu changed the title ~~[wip]update pause image to 3.4.1~~ update pause image to 3.4.1 Feb 14, 2021

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 14, 2021

saschagrunert approved these changes Feb 15, 2021

View reviewed changes

openshift-ci-robot added dco-signoff: no Indicates the PR's author has not DCO signed all their commits. and removed dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Mar 19, 2021

pacoxu changed the title ~~update pause image to 3.4.1~~ update pause image to 3.5（3.4.1 for multi-arch support and 3.5 for non-root） Mar 19, 2021

saschagrunert mentioned this pull request Mar 23, 2021

Update pause image to 3.5 #4663

Closed

pacoxu force-pushed the update/pause-image branch from 8720355 to 6de2734 Compare March 29, 2021 05:58

openshift-ci-robot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Mar 29, 2021

pacoxu force-pushed the update/pause-image branch from 6de2734 to 6d25b85 Compare March 29, 2021 08:44

TomSweeneyRedHat reviewed Mar 29, 2021

View reviewed changes

internal/config/migrate/from_1_17.go Show resolved Hide resolved

update pause image to 3.5 for non-root

6441ba5

Signed-off-by: pacoxu <[email protected]>

pacoxu force-pushed the update/pause-image branch from 6d25b85 to 6441ba5 Compare March 31, 2021 03:15

saschagrunert approved these changes Mar 31, 2021

View reviewed changes

openshift-ci-robot assigned saschagrunert Mar 31, 2021

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2021

openshift-merge-robot merged commit a2fec8a into cri-o:master Mar 31, 2021

update pause image to 3.5（3.4.1 for multi-arch support and 3.5 for non-root） #4550

update pause image to 3.5（3.4.1 for multi-arch support and 3.5 for non-root） #4550

Uh oh!

Conversation

pacoxu commented Feb 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Uh oh!

openshift-ci-robot commented Feb 8, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pacoxu commented Feb 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

saschagrunert left a comment

Choose a reason for hiding this comment

Uh oh!

pacoxu commented Feb 16, 2021

Uh oh!

pacoxu commented Feb 19, 2021

Uh oh!

codecov bot commented Mar 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

pacoxu commented Mar 22, 2021

Uh oh!

TomSweeneyRedHat commented Mar 22, 2021

Uh oh!

haircommander commented Mar 22, 2021

Uh oh!

pacoxu commented Mar 29, 2021

Uh oh!

pacoxu commented Mar 29, 2021

Uh oh!

Uh oh!

pacoxu commented Mar 31, 2021

Uh oh!

saschagrunert left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Mar 31, 2021

Uh oh!

pacoxu commented Mar 31, 2021

Uh oh!

pacoxu commented Mar 31, 2021

Uh oh!

openshift-ci bot commented Mar 31, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

pacoxu commented Feb 8, 2021 •

edited

Loading

pacoxu commented Feb 14, 2021 •

edited

Loading

codecov bot commented Mar 19, 2021 •

edited

Loading

openshift-ci bot commented Mar 31, 2021 •

edited

Loading