Update pause image to 3.5 #4663
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #4663 +/- ##
==========================================
- Coverage 40.95% 40.94% -0.01%
==========================================
Files 110 110
Lines 9545 9547 +2
==========================================
Hits 3909 3909
- Misses 5189 5191 +2
Partials 447 447 |
We upgraded the pause image to 3.5, which is now reflected in CRI-O as well as our config migration. Signed-off-by: Sascha Grunert <[email protected]>
|
@saschagrunert: The following test failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@saschagrunert: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| func migrateFrom1_20(cfg *config.Config) error { | ||
| // Upgrade pause image | ||
| logrus.Infof("Checking for pause_image, which now should be k8s.gcr.io/pause:3.5 instead of k8s.gcr.io/pause:3.2") | ||
| if cfg.PauseImage == "k8s.gcr.io/pause:3.2" { |
There was a problem hiding this comment.
Would this be better?
| if cfg.PauseImage == "k8s.gcr.io/pause:3.2" { | |
| if cfg.PauseImage != config.DefaultPauseImage { |
There was a problem hiding this comment.
This would change the value to k8s.gcr.io/pause:3.2, which would change the logic there :)
|
Closing in favor of #4550 |
What type of PR is this?
/kind feature
What this PR does / why we need it:
We upgraded the pause image to 3.5, which is now reflected in CRI-O as
well as our config migration.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?