[1.19] Point to k8s release-1.19 branch for tests #4008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3dbb971 to
e56ff3c
Compare
Contributor
|
Changes LGTM once tests are happy |
Member
Author
|
/retest |
Codecov Report
@@ Coverage Diff @@
## release-1.19 #4008 +/- ##
=============================================
Coverage 41.58% 41.58%
=============================================
Files 110 110
Lines 9046 9046
=============================================
Hits 3762 3762
Misses 4944 4944
Partials 340 340 |
Member
Author
|
/retest |
Member
|
/hold we've decided to wait until we stop forwarding from master to do this (should be in a week or two) |
And update the tutorial doc to say release-1.19 instead of release-1.18. Signed-off-by: Urvashi Mohnani <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: umohnani8 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
/hold cancel This can be merged now. @mrunalp @haircommander PTAL |
Member
|
/lgtm |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Urvashi Mohnani [email protected]
What type of PR is this?
/kind dependency-change
What this PR does / why we need it:
And update the tutorial doc to say release-1.19 instead
of release-1.18.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?