[release-1.19] Revert "runtime_vm: Cleanup process when the Container is Stopped" #4143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 814c1bb. We cannot simply delete the container when its status changes to stopped. The intention of this fix is okay-ish, but implemented in the wrong layer. What containerd does is calling Shutdown(), when the *pod* is finished, and that's what we should do as well. Signed-off-by: Fabiano Fidêncio <[email protected]>
Codecov Report
@@ Coverage Diff @@
## release-1.19 #4143 +/- ##
================================================
+ Coverage 41.58% 41.60% +0.01%
================================================
Files 110 110
Lines 9046 9043 -3
================================================
Hits 3762 3762
+ Misses 4944 4941 -3
Partials 340 340 |
Member
|
/lgtm |
Member
|
/retest |
mrunalp
approved these changes
Sep 11, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fidencio, mrunalp The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/lgtm |
Member
|
/retest |
2 similar comments
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
Contributor
Author
|
/test e2e_features_fedora |
Contributor
Author
|
/test e2e-aws |
This was referenced Nov 2, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
This reverts commit 814c1bb.
We cannot simply delete the container when its status changes to
stopped. The intention of this fix is okay-ish, but implemented in the
wrong layer.
What containerd does is calling Shutdown(), when the pod is finished,
and that's what we should do as well.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?