[1.19] managed ns: ignore PID not initialized on sandbox creation
#4160
Conversation
everytime we create a sandbox with a pinned namespace, we spit out an error that says: `Pid for infra container $id not found: PID not initialized` in the pinned namespace case, we create the namespaces, create the networking stack (giving the created net namespace to the plugin), THEN create the pod. Thus, we don't expect the infra container to be initialized. Fix this by ignoring ErrNotInitialized when we're fetching the infraPid when finding the namespaces. We can safely do this because the managed namespace case is covered (we don't use the pid, but use the managed namespace struct we've created) And in the non-managed namespace case, we will (correctly) fail later because we return an invalid PID, which matches our invalid infra container. Signed-off-by: Peter Hunt <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
PID not initialized on sandbox creationPID not initialized on sandbox creation
Codecov Report
@@ Coverage Diff @@
## release-1.19 #4160 +/- ##
=============================================
Coverage 41.58% 41.58%
=============================================
Files 110 110
Lines 9046 9046
=============================================
Hits 3762 3762
Misses 4944 4944
Partials 340 340 |
|
/retest |
|
/lgtm |
|
/retest |
|
@haircommander: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest |
What type of PR is this?
/kind bug
What this PR does / why we need it:
everytime we create a sandbox with a pinned namespace, we spit out an error that says:
Pid for infra container $id not found: PID not initializedin the pinned namespace case, we create the namespaces, create the networking stack (giving the created net namespace to the plugin), THEN create the pod.
Thus, we don't expect the infra container to be initialized.
Fix this by ignoring ErrNotInitialized when we're fetching the infraPid when finding the namespaces.
We can safely do this because the managed namespace case is covered (we don't use the pid, but use the managed namespace struct we've created)
And in the non-managed namespace case, we will (correctly) fail later because we return an invalid PID, which matches our invalid infra container.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?