[release-1.19] config: set internal RootConfig to default storage if not specified #4161
Conversation
After we pull in the initial config, it is our source of truth for telling the world where our container storage is in particular, if we, say, have an empty `storage` entry, we will return `StorageDriver: ""` on an Inspect request the problem is, that is a lie. c/storage populates defaults for us, so we actually use overlay in that scenerio. we don't encounter this normally, because if the toml field isn't specified (as it isn't by default), then we inherit the information from the default config However, if a user (or an ignition config) overrides those fields to empty, we will listen to it as the source of truth, and never update to what is actually being used Fix this by inheriting the values from c/storage on the validation step. Signed-off-by: Peter Hunt <[email protected]>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@openshift-cherrypick-robot: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Codecov Report
@@ Coverage Diff @@
## release-1.19 #4161 +/- ##
================================================
+ Coverage 41.58% 41.68% +0.10%
================================================
Files 110 110
Lines 9046 9053 +7
================================================
+ Hits 3762 3774 +12
+ Misses 4944 4938 -6
- Partials 340 341 +1 |
|
/lgtm |
This is an automated cherry-pick of #4131
/assign haircommander