[1.19] oci: parse stat file instead of using ctime #4166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as we have seen the ctime of it's proc entry fluctuate, and the process start time (item 22 in /proc/pid/stat) could be more reliable Signed-off-by: Peter Hunt <[email protected]>
Codecov Report
@@ Coverage Diff @@
## release-1.19 #4166 +/- ##
================================================
+ Coverage 41.68% 41.77% +0.09%
================================================
Files 110 110
Lines 9053 9067 +14
================================================
+ Hits 3774 3788 +14
Misses 4938 4938
Partials 341 341 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/lgtm |
Member
Author
|
/retest |
Member
Author
|
/test e2e-aws |
This was referenced Nov 2, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
pick of #4146
including #4154
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?