Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[release-1.19] Remove git-validation in favor of prow/golangci-lint #4169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Sep 7, 2020
Merged

[release-1.19] Remove git-validation in favor of prow/golangci-lint #4169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@ workflows:
requires:
- build
- docs-validation
- git-validation
- integration
- integration:
name: integration-critest
Expand Down Expand Up @@ -290,22 +289,6 @@ jobs:
paths:
- *gocache

git-validation:
executor: container
steps:
- checkout
- restore_cache:
keys:
- v1-git-validation-{{ checksum "go.sum" }}
- run:
name: git validation
command: make git-validation
- save_cache:
key: v1-git-validation-{{ checksum "go.sum" }}
paths:
- *gocache
- build/bin/git-validation

dependencies:
executor: container
steps:
Expand Down
9 changes: 0 additions & 9 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ SOURCE_DATE_EPOCH ?= $(shell date +%s)
GO_MD2MAN ?= ${BUILD_BIN_PATH}/go-md2man
GINKGO := ${BUILD_BIN_PATH}/ginkgo
MOCKGEN := ${BUILD_BIN_PATH}/mockgen
GIT_VALIDATION := ${BUILD_BIN_PATH}/git-validation
GOLANGCI_LINT := ${BUILD_BIN_PATH}/golangci-lint
GO_MOD_OUTDATED := ${BUILD_BIN_PATH}/go-mod-outdated
RELEASE_NOTES := ${BUILD_BIN_PATH}/release-notes
Expand Down Expand Up @@ -272,9 +271,6 @@ ${GINKGO}:
${MOCKGEN}:
$(call go-build,./vendor/github.com/golang/mock/mockgen)

${GIT_VALIDATION}:
$(call go-build,./vendor/github.com/vbatts/git-validation)

${RELEASE_NOTES}:
$(call go-build,./vendor/k8s.io/release/cmd/release-notes)

Expand Down Expand Up @@ -503,11 +499,6 @@ uninstall:
rm -f $(OCIUMOUNTINSTALLDIR)/crio-umount.conf
rm -f $(CRICTL_CONFIG_DIR)/crictl.yaml

git-validation: .gopathok ${GIT_VALIDATION}
GIT_CHECK_EXCLUDE="vendor" \
${GIT_VALIDATION} -v -run DCO,short-subject,dangling-whitespace \
-range ${GIT_MERGE_BASE}..HEAD

docs-validation:
$(GO_RUN) -tags "$(BUILDTAGS)" ./test/docs-validation

Expand Down
1 change: 0 additions & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ require (
github.com/soheilhy/cmux v0.1.4
github.com/syndtr/gocapability v0.0.0-20180916011248-d98352740cb2
github.com/urfave/cli/v2 v2.2.0
github.com/vbatts/git-validation v1.1.0
github.com/vishvananda/netlink v1.1.0
golang.org/x/net v0.0.0-20200707034311-ab3426394381
golang.org/x/sync v0.0.0-20200625203802-6e8e738ad208
Expand Down
1 change: 0 additions & 1 deletion internal/tools/tools.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import (
_ "github.com/golang/mock/mockgen"
_ "github.com/onsi/ginkgo/ginkgo"
_ "github.com/psampaz/go-mod-outdated"
_ "github.com/vbatts/git-validation"
_ "k8s.io/release/cmd/release-notes"
_ "mvdan.cc/sh/v3/cmd/shfmt"
)
13 changes: 0 additions & 13 deletions vendor/github.com/hashicorp/go-version/.travis.yml
View file
Open in desktop

This file was deleted.

Loading