[release-1.19] Remove git-validation in favor of prow/golangci-lint #4169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The whitespace checks are mostly done by our linters and the DCO verification will be done by prow. This means we can remove git-validation if we agree on skipping the git commit message check. Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert
approved these changes
Sep 7, 2020
Member
saschagrunert
left a comment
There was a problem hiding this comment.
LGTM, hopefully fixes the CI on this release branch
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: openshift-cherrypick-robot, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/lgtm |
Codecov Report
@@ Coverage Diff @@
## release-1.19 #4169 +/- ##
=============================================
Coverage 41.68% 41.68%
=============================================
Files 110 110
Lines 9053 9053
=============================================
Hits 3774 3774
Misses 4938 4938
Partials 341 341 |
Member
|
/retest |
This was referenced Nov 2, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #4119
/assign saschagrunert