-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[1.19] Add option to drop infra container #4186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.19] Add option to drop infra container #4186
Conversation
Signed-off-by: Peter Hunt <[email protected]>
as well as update existing tests to allow drop_infra_ctr to be true or false by default Signed-off-by: Peter Hunt <[email protected]>
specifically, set RUNTIME_NAME and CONTAINER_DEFAULT_RUNTIME if it's set as such Signed-off-by: Peter Hunt <[email protected]>
sysctls must be passed to pinns of the format -s 'key=value'+'key2=value2' also, move the pinns source code to `pinns/src` to clean up the top level directory a bit Signed-off-by: Peter Hunt <[email protected]>
as it would otherwise unconditionally have pexit() called Signed-off-by: Peter Hunt <[email protected]>
Signed-off-by: Peter Hunt <[email protected]>
to hold crio specific annotations until they are stable enough to put in containers/common Signed-off-by: Peter Hunt <[email protected]>
as well as a constructor for a spoofed container a Spoofed() container is one that exists in cri-o's state, but not in the runtime This allows us to drop the infra, but keep bookkeeping standardized (for instance, when we restore cri-o, we look at the container's state directory) Signed-off-by: Peter Hunt <[email protected]>
to allow the sandbox to decide when it needs an infra container Signed-off-by: Peter Hunt <[email protected]>
in the initial (very old) implementation of a dropped infra, infra containers were allowed to be nil This is no longer the case, so we can remove traces of that old implementation Signed-off-by: Peter Hunt <[email protected]>
this commit includes: - propegate sysctls from pod creation down to pinns - use the annotations package for userns and spoofed containers - add restore code for when a container was spoofed - query a runtime handler based on the string instead of by container - this allows us to query the runtime handler before we create the container to allow it to be spoofed - drop the infra container when the pod is not kernel separated, and when NeedsInfra is false Signed-off-by: Peter Hunt <[email protected]>
|
/retest |
Codecov Report
@@ Coverage Diff @@
## release-1.19 #4186 +/- ##
================================================
- Coverage 41.77% 41.76% -0.02%
================================================
Files 110 110
Lines 9067 9169 +102
================================================
+ Hits 3788 3829 +41
- Misses 4938 4997 +59
- Partials 341 343 +2 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, mrunalp The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/retest |
|
/test e2e-aws |
|
/retest |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?