Thanks to visit codestin.com
Credit goes to github.com

Skip to content

bump to v1.19.0 #4188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Sep 12, 2020
Merged

bump to v1.19.0 #4188

openshift-merge-robot merged 1 commit into from
Sep 12, 2020

Conversation

@haircommander
Copy link
Member

@haircommander haircommander commented Sep 12, 2020

Signed-off-by: Peter Hunt [email protected]

What type of PR is this?

/kind documentation

/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

as title says!

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

none

@haircommander
bump to v1.19.0
87aa1a7 
Signed-off-by: Peter Hunt <[email protected]>
@openshift-ci-robot openshift-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Sep 12, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 12, 2020

@haircommander: The label(s) kind/ cannot be applied, because the repository doesn't have them

Details

In response to this:

Signed-off-by: Peter Hunt [email protected]

What type of PR is this?

/kind documentation

/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

as title says!

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

none

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2020
@haircommander
Copy link
Member Author

haircommander commented Sep 12, 2020

/kind documentation

@codecov
Copy link

codecov bot commented Sep 12, 2020

Codecov Report

Merging #4188 into release-1.19 will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           release-1.19    #4188   +/-   ##
=============================================
  Coverage         41.75%   41.75%           
=============================================
  Files               110      110           
  Lines              9163     9163           
=============================================
  Hits               3826     3826           
  Misses             4994     4994           
  Partials            343      343

@haircommander
Copy link
Member Author

haircommander commented Sep 12, 2020

/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 12, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [haircommander,mrunalp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mrunalp
Copy link
Member

mrunalp commented Sep 12, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2020
@openshift-merge-robot openshift-merge-robot merged commit 1852363 into cri-o:release-1.19 Sep 12, 2020
@saschagrunert
Copy link
Member

saschagrunert commented Sep 14, 2020

This commit basically broke the build of the release-notes tool: 15aa81b

Working on a fix.

@saschagrunert saschagrunert mentioned this pull request Sep 14, 2020
Merged
This was referenced Nov 2, 2020
Closed
Merged
@openshift-ci-robot openshift-ci-robot mentioned this pull request Feb 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp mrunalp approved these changes

@runcom runcom Awaiting requested review from runcom runcom is a code owner

@sameo sameo Awaiting requested review from sameo

@saschagrunert saschagrunert Awaiting requested review from saschagrunert

Assignees

@mrunalp mrunalp

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@haircommander @openshift-ci-robot @mrunalp @saschagrunert @openshift-merge-robot