Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bump version to 1.19-rc1 #4106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Aug 22, 2020
Merged

Bump version to 1.19-rc1 #4106

openshift-merge-robot merged 1 commit into from
Aug 22, 2020
+1 −1

Conversation

@umohnani8
Copy link
Member

@umohnani8 umohnani8 commented Aug 20, 2020

Signed-off-by: Urvashi Mohnani [email protected]

none

@openshift-ci-robot openshift-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Aug 20, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2020
@haircommander
Copy link
Member

haircommander commented Aug 20, 2020

/retest

LGTM

@mrunalp
Copy link
Member

mrunalp commented Aug 20, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2020
@haircommander
Copy link
Member

haircommander commented Aug 20, 2020 

 * 85915147a "Merge remote-tracking branch 'origin/master' into release-1.19" ... FAIL
  - FAIL - has whitespace errors. See `git show --check 85915147a419c1880e7ff22630bf87d40766c27c`.

damn git validation broke

saschagrunert
saschagrunert reviewed Aug 21, 2020
View reviewed changes
@umohnani8
Bump version to 1.19-rc1
4578b5f 
Signed-off-by: Urvashi Mohnani <[email protected]>
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2020
saschagrunert
saschagrunert approved these changes Aug 21, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Aug 21, 2020

Codecov Report

Merging #4106 into release-1.19 will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           release-1.19    #4106   +/-   ##
=============================================
  Coverage         41.58%   41.58%           
=============================================
  Files               110      110           
  Lines              9042     9042           
=============================================
  Hits               3760     3760           
  Misses             4943     4943           
  Partials            339      339

@giuseppe
Copy link
Member

giuseppe commented Aug 22, 2020

/retest

giuseppe
giuseppe approved these changes Aug 22, 2020
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 22, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, mrunalp, saschagrunert, umohnani8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [giuseppe,mrunalp,saschagrunert,umohnani8]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 22, 2020 •
edited
Loading

@umohnani8: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/openshift-jenkins/e2e_crun_cgroupv2 4578b5f link /test e2e_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mrunalp
Copy link
Member

mrunalp commented Aug 22, 2020

/test integration_rhel

@openshift-merge-robot openshift-merge-robot merged commit ac7f451 into cri-o:release-1.19 Aug 22, 2020
This was referenced Nov 2, 2020
Closed
Merged
@openshift-ci-robot openshift-ci-robot mentioned this pull request Feb 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp mrunalp approved these changes

@giuseppe giuseppe giuseppe approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

@runcom runcom Awaiting requested review from runcom runcom is a code owner

@fidencio fidencio Awaiting requested review from fidencio

Assignees

@mrunalp mrunalp

@giuseppe giuseppe

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@umohnani8 @haircommander @mrunalp @giuseppe @openshift-ci-robot @saschagrunert @openshift-merge-robot