Remove git-validation in favor of prow/golangci-lint #4119
Conversation
The whitespace checks are mostly done by our linters and the DCO verification will be done by prow. This means we can remove git-validation if we agree on skipping the git commit message check. Signed-off-by: Sascha Grunert <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #4119 +/- ##
=======================================
Coverage 40.35% 40.35%
=======================================
Files 110 110
Lines 9346 9346
=======================================
Hits 3772 3772
Misses 5223 5223
Partials 351 351 |
|
@saschagrunert for clarity, what does the "git commit message check" do/check? |
Just that the commit message subject is not longer than 90 characters. |
|
LGTM. I am fine with removing the 90 character check for the commit subject. @mrunalp @haircommander wdyt? |
|
/retest |
|
@saschagrunert: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/cherrypick release-1.19 |
|
@saschagrunert: new pull request created: #4169 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind dependency-change
What this PR does / why we need it:
The whitespace checks are mostly done by our linters and the DCO
verification will be done by prow. This means we can remove
git-validation if we agree on skipping the git commit message check.
Which issue(s) this PR fixes:
Refers to #4112
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?