-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[1.19] managed ns: report namespace cleanup failure by default #4126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.19] managed ns: report namespace cleanup failure by default #4126
Conversation
Signed-off-by: Peter Hunt <[email protected]>
|
/kind cleanup |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, mrunalp The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## release-1.19 #4126 +/- ##
=============================================
Coverage 41.58% 41.58%
=============================================
Files 110 110
Lines 9042 9042
=============================================
Hits 3760 3760
Misses 4943 4943
Partials 339 339 |
|
/retest |
1 similar comment
|
/retest |
|
LGTM |
|
/test e2e-aws |
1 similar comment
|
/test e2e-aws |
|
@haircommander: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test integration_crun |
Signed-off-by: Peter Hunt [email protected]
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?