Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[1.19] runtime_vm: set Pid and InitPid for VM runtimes #4265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Oct 14, 2020
Merged

[1.19] runtime_vm: set Pid and InitPid for VM runtimes #4265

openshift-merge-robot merged 1 commit into from
Oct 14, 2020

Conversation

@fgiudici
Copy link
Contributor

@fgiudici fgiudici commented Oct 14, 2020

What type of PR is this?

/kind bug

What this PR does / why we need it:

Initialize the InitPid when starting a pod with a vm runtime.

Which issue(s) this PR fixes:

Fixes #4264

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@liubin @fgiudici
runtime_vm: set Pid and InitPid for VM runtimes
6f55aee 
If Pid or InitPid is not set correctly, then c.Alive()
will return false, and all calls depending on c.Alive()
will fail.

Fixes: cri-o#4224

Signed-off-by: bin liu <[email protected]>
(cherry picked from commit 6913515)

Fixes: cri-o#4264

Signed-off-by: Francesco Giudici <[email protected]>
@openshift-ci-robot openshift-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. labels Oct 14, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 14, 2020

Hi @fgiudici. Thanks for your PR.

I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 14, 2020
@haircommander
Copy link
Member

haircommander commented Oct 14, 2020

/ok-to-test

thanks @fgiudici, when we target against a release branch, we usually prefix the title with [1.19] to make it easier to see where it's targeted. could you retitle please?

/approve

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 14, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 14, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fgiudici, haircommander

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2020
@TomSweeneyRedHat
Copy link
Contributor

TomSweeneyRedHat commented Oct 14, 2020

LGTM
assuming happy tests

@codecov
Copy link

codecov bot commented Oct 14, 2020

Codecov Report

Merging #4265 into release-1.19 will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@               Coverage Diff                @@
##           release-1.19    #4265      +/-   ##
================================================
- Coverage         39.57%   39.55%   -0.02%     
================================================
  Files               110      110              
  Lines              8291     8294       +3     
================================================
  Hits               3281     3281              
- Misses             4683     4686       +3     
  Partials            327      327

@fgiudici fgiudici changed the title runtime_vm: set Pid and InitPid for VM runtimes [1.19] runtime_vm: set Pid and InitPid for VM runtimes Oct 14, 2020
@fidencio
Copy link
Contributor

fidencio commented Oct 14, 2020

/lgtm

Thanks, @fgiudici!

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2020
@fidencio
Copy link
Contributor

fidencio commented Oct 14, 2020

/retest

@openshift-merge-robot openshift-merge-robot merged commit 4372f43 into cri-o:release-1.19 Oct 14, 2020
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 14, 2020

@fgiudici: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/openshift-jenkins/e2e_crun_cgroupv2 6f55aee link /test e2e_cgroupv2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

This was referenced Nov 2, 2020
Closed
Merged
@openshift-ci-robot openshift-ci-robot mentioned this pull request Feb 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhatdan rhatdan Awaiting requested review from rhatdan

@sboeuf sboeuf Awaiting requested review from sboeuf

Assignees

@fidencio fidencio

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@fgiudici @openshift-ci-robot @haircommander @TomSweeneyRedHat @fidencio @openshift-merge-robot @liubin