Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[1.19] server: cleanup container in runtime after failed creation #4201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Sep 16, 2020
Merged

[1.19] server: cleanup container in runtime after failed creation #4201

openshift-merge-robot merged 1 commit into from
Sep 16, 2020

Conversation

@haircommander
Copy link
Member

@haircommander haircommander commented Sep 15, 2020

What type of PR is this?

/kind bug

What this PR does / why we need it:

partial cherry-pick of #4198

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fixed a bug where a container creation failure caused that container to leak in the runtime

@haircommander
server: cleanup container in runtime after failed creation
673f911 
otherwise, we leak containers in runc

Signed-off-by: Peter Hunt <[email protected]>
@openshift-ci-robot openshift-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. labels Sep 15, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2020
@codecov
Copy link

codecov bot commented Sep 15, 2020

Codecov Report

Merging #4201 into release-1.19 will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@               Coverage Diff                @@
##           release-1.19    #4201      +/-   ##
================================================
- Coverage         41.75%   41.73%   -0.03%     
================================================
  Files               110      110              
  Lines              9163     9168       +5     
================================================
  Hits               3826     3826              
- Misses             4994     4999       +5     
  Partials            343      343

@haircommander
Copy link
Member Author

haircommander commented Sep 15, 2020

/retest

@haircommander
Copy link
Member Author

haircommander commented Sep 15, 2020

weird failure on integration_fedora:


not ok 11 config dir should fail with invalid option
# (in test file ./config.bats, line 38)
#   `RES=$(cat "$CRIO_LOG")' failed
# cat: /tmp/tmp.MPXCSj4ECK/crio.log: No such file or directory

ref

@mrunalp
Copy link
Member

mrunalp commented Sep 15, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2020
@mrunalp
Copy link
Member

mrunalp commented Sep 15, 2020

/test integration_rhel

@haircommander
Copy link
Member Author

haircommander commented Sep 16, 2020

/retest

@haircommander
Copy link
Member Author

haircommander commented Sep 16, 2020

/cherry-pick release-1.18

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Sep 16, 2020

@haircommander: once the present PR merges, I will cherry-pick it on top of release-1.18 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@haircommander
Copy link
Member Author

haircommander commented Sep 16, 2020

/cherry-pick release-1.17

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Sep 16, 2020

@haircommander: once the present PR merges, I will cherry-pick it on top of release-1.17 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

saschagrunert
saschagrunert approved these changes Sep 16, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 16, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, mrunalp, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [haircommander,mrunalp,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit d802e19 into cri-o:release-1.19 Sep 16, 2020
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 16, 2020
Closed
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Sep 16, 2020

@haircommander: new pull request created: #4205

Details

In response to this:

/cherry-pick release-1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 16, 2020
Closed
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Sep 16, 2020

@haircommander: new pull request created: #4206

Details

In response to this:

/cherry-pick release-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@haircommander haircommander mentioned this pull request Sep 16, 2020
Merged
@sferich888
Copy link

sferich888 commented Sep 24, 2020

Relates to https://bugzilla.redhat.com/show_bug.cgi?id=1882501 for tracking purposes.

@haircommander haircommander mentioned this pull request Oct 1, 2020
Merged
This was referenced Nov 2, 2020
Closed
Merged
@openshift-ci-robot openshift-ci-robot mentioned this pull request Feb 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp mrunalp approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

@runcom runcom Awaiting requested review from runcom runcom is a code owner

@fidencio fidencio Awaiting requested review from fidencio

Assignees

@mrunalp mrunalp

@saschagrunert saschagrunert

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@haircommander @mrunalp @openshift-cherrypick-robot @openshift-ci-robot @sferich888 @saschagrunert @openshift-merge-robot