test/devices.bats: nits #4369

kolyshkin · 2020-11-13T20:13:15Z

What type of PR is this?

/kind ci

What this PR does / why we need it:

A few minor fixes and improvements to test/devices.bats. Please see individual commits for details.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

This saves some time (a few seconds per test at least) as we avoid running setup_test (and cleanup_test has nothing to clean up), and removes some code duplication. Signed-off-by: Kir Kolyshkin <[email protected]>

haircommander · 2020-11-13T20:15:45Z

/approve
LGTM

codecov · 2020-11-13T20:35:53Z

Codecov Report

Merging #4369 (b3000eb) into master (48ee902) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4369   +/-   ##
=======================================
  Coverage   39.29%   39.29%           
=======================================
  Files         112      112           
  Lines        8835     8835           
=======================================
  Hits         3472     3472           
  Misses       4977     4977           
  Partials      386      386

...and add a status check to one case where we use run, to make it more obvious that `run` is really needed here. Signed-off-by: Kir Kolyshkin <[email protected]>

openshift-ci-robot · 2020-11-13T22:20:59Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, kolyshkin, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [haircommander,kolyshkin,mrunalp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kolyshkin · 2020-11-14T03:52:16Z

/retest

kolyshkin · 2020-11-16T10:39:56Z

OK, we need to fix the test to use a device other than /dev/loop-control, as it is not supposed to be read from or written to (it's used with ioctls).

not ok 80 additional devices permissions
# (in test file ./devices.bats, line 79)
#   `[[ "$output" == *"Invalid argument"* ]]' failed
# time="2020-11-14T04:11:21Z" level=info msg="Starting CRI-O, version: 1.20.0-dev, git: 245ed8e754e9e084519dc9545d071cf06a1509c7(dirty)"
# level=info msg="Using default capabilities: CAP_CHOWN, CAP_DAC_OVERRIDE, CAP_FSETID, CAP_FOWNER, CAP_SETGID, CAP_SETUID, CAP_SETPCAP, CAP_NET_BIND_SERVICE, CAP_KILL"
# 2bcf6fb7938c51d616187edc92d1fd7d2f22b602d743cf4b0e18ac759fc6a609
# /dev/loop-control

So adding WIP for now.

Using /dev/loop-control is problematic since it is not supposed to be read from or written to. Use /dev/kmsg, and actually enable the write test. Signed-off-by: Kir Kolyshkin <[email protected]>

kolyshkin · 2020-11-16T18:25:34Z

/dev/kmsg seems like a good fit. Updated.

kolyshkin · 2020-11-16T18:34:35Z

Seems like some tests failed to restart after a force push

/retest

kolyshkin · 2020-11-16T20:55:24Z

/retest

(e2e-aws is still supposed to fail)

kolyshkin · 2020-11-16T21:12:30Z

/kind ci

kolyshkin · 2020-11-16T21:12:57Z

This one is ready

kolyshkin · 2020-11-17T18:32:25Z

/test e2e-aws

kolyshkin · 2020-11-18T05:02:14Z

/test e2e-aws

haircommander · 2020-11-18T15:21:50Z

/lgtm

haircommander · 2020-11-18T19:20:47Z

/retest

kolyshkin · 2020-11-19T01:24:21Z

OK it seems that openshift/release#13708 was a mistake :(

Opened a revert PR: openshift/release#13736

kolyshkin · 2020-11-19T04:14:54Z

/retest

kolyshkin · 2020-11-19T20:18:28Z

/retest

kolyshkin · 2020-11-19T23:41:44Z

Same failure in e2e-agnistic and images:

the build machine-os-content failed after 2m14s with reason DockerBuildFailed: Dockerfile build strategy has failed.

Error: Failed to synchronize cache for repo 'updates'
subprocess exited with status 1
subprocess exited with status 1
STEP 5: FROM image-registry.openshift-image->registry.svc:5...3fc231a7ed11a3cf5a3be7574f867b84455890a6389e15fc14c84621283
error: build error: error building at STEP "RUN set -x && ...-ci-dev overlay RPMs" --branch=cri-o-ci-dev": exit status 1

/test images
/test e2e-agnostic

kolyshkin · 2020-11-21T18:25:14Z

/retest

(two jobs never reported status back, and e2e-agnostic got many failures)

kolyshkin · 2020-11-23T20:27:17Z

/test e2e-agnostic

kolyshkin · 2020-11-25T01:54:35Z

/test e2e-agnostic

kolyshkin · 2020-11-27T20:51:21Z

/test e2e-agnostic

kolyshkin · 2020-11-28T03:27:21Z

/test e2e-agnostic

kolyshkin · 2020-11-28T05:33:32Z

/test e2e-agnostic

kolyshkin · 2020-11-30T03:31:28Z

/retest

kolyshkin · 2020-12-01T22:49:36Z

/test e2e-agnostic

kolyshkin · 2020-12-08T01:46:56Z

/test critest_fedora

haircommander · 2020-12-08T21:06:42Z

/cherry-pick release-1.20

openshift-cherrypick-robot · 2020-12-08T21:06:50Z

@haircommander: new pull request created: #4418

Details

In response to this:

/cherry-pick release-1.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

test/devices.bats: skip earlier

7b910a0

This saves some time (a few seconds per test at least) as we avoid running setup_test (and cleanup_test has nothing to clean up), and removes some code duplication. Signed-off-by: Kir Kolyshkin <[email protected]>

kolyshkin requested review from mrunalp and runcom as code owners November 13, 2020 20:13

openshift-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Nov 13, 2020

openshift-ci-robot requested review from fidencio and sboeuf November 13, 2020 20:13

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2020

test/devices.bats: rm unneeded run

a53c2a7

...and add a status check to one case where we use run, to make it more obvious that `run` is really needed here. Signed-off-by: Kir Kolyshkin <[email protected]>

kolyshkin force-pushed the test-devices branch from 881dd66 to 245ed8e Compare November 13, 2020 22:03

mrunalp approved these changes Nov 13, 2020

View reviewed changes

kolyshkin changed the title ~~test/devices.bats: nits~~ [WIP] test/devices.bats: nits Nov 16, 2020

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 16, 2020

test/devices.bats: fix "additional device permissions" case

b3000eb

Using /dev/loop-control is problematic since it is not supposed to be read from or written to. Use /dev/kmsg, and actually enable the write test. Signed-off-by: Kir Kolyshkin <[email protected]>

kolyshkin force-pushed the test-devices branch from 245ed8e to b3000eb Compare November 16, 2020 18:26

kolyshkin changed the title ~~[WIP] test/devices.bats: nits~~ test/devices.bats: nits Nov 16, 2020

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 16, 2020

openshift-ci-robot added the kind/ci Categorizes issue or PR as related to CI label Nov 16, 2020

openshift-ci-robot assigned haircommander Nov 18, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2020

openshift-merge-robot merged commit 6989674 into cri-o:master Dec 8, 2020

openshift-cherrypick-robot mentioned this pull request Dec 8, 2020

[release-1.20] test/devices.bats: nits #4418

Merged

test/devices.bats: nits #4369

test/devices.bats: nits #4369

Uh oh!

Conversation

kolyshkin commented Nov 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Uh oh!

haircommander commented Nov 13, 2020

Uh oh!

codecov bot commented Nov 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

openshift-ci-robot commented Nov 13, 2020

Uh oh!

kolyshkin commented Nov 14, 2020

Uh oh!

kolyshkin commented Nov 16, 2020

Uh oh!

kolyshkin commented Nov 16, 2020

Uh oh!

kolyshkin commented Nov 16, 2020

Uh oh!

kolyshkin commented Nov 16, 2020

Uh oh!

kolyshkin commented Nov 16, 2020

Uh oh!

kolyshkin commented Nov 16, 2020

Uh oh!

kolyshkin commented Nov 17, 2020

Uh oh!

kolyshkin commented Nov 18, 2020

Uh oh!

haircommander commented Nov 18, 2020

Uh oh!

haircommander commented Nov 18, 2020

Uh oh!

kolyshkin commented Nov 19, 2020

Uh oh!

kolyshkin commented Nov 19, 2020

Uh oh!

kolyshkin commented Nov 19, 2020

Uh oh!

kolyshkin commented Nov 19, 2020

Uh oh!

kolyshkin commented Nov 21, 2020

Uh oh!

kolyshkin commented Nov 23, 2020

Uh oh!

kolyshkin commented Nov 25, 2020

Uh oh!

kolyshkin commented Nov 27, 2020

Uh oh!

kolyshkin commented Nov 28, 2020

Uh oh!

kolyshkin commented Nov 28, 2020

Uh oh!

kolyshkin commented Nov 30, 2020

Uh oh!

kolyshkin commented Dec 1, 2020

Uh oh!

kolyshkin commented Dec 8, 2020

Uh oh!

haircommander commented Dec 8, 2020

Uh oh!

openshift-cherrypick-robot commented Dec 8, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

kolyshkin commented Nov 13, 2020 •

edited

Loading

codecov bot commented Nov 13, 2020 •

edited

Loading