[release-1.20] test/devices.bats: nits #4418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This saves some time (a few seconds per test at least) as we avoid running setup_test (and cleanup_test has nothing to clean up), and removes some code duplication. Signed-off-by: Kir Kolyshkin <[email protected]>
...and add a status check to one case where we use run, to make it more obvious that `run` is really needed here. Signed-off-by: Kir Kolyshkin <[email protected]>
Using /dev/loop-control is problematic since it is not supposed to be read from or written to. Use /dev/kmsg, and actually enable the write test. Signed-off-by: Kir Kolyshkin <[email protected]>
Codecov Report
@@ Coverage Diff @@
## release-1.20 #4418 +/- ##
=============================================
Coverage 40.50% 40.50%
=============================================
Files 116 116
Lines 9330 9330
=============================================
Hits 3779 3779
Misses 5125 5125
Partials 426 426 |
mrunalp
approved these changes
Dec 9, 2020
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrunalp, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #4369
/assign haircommander