Thanks to visit codestin.com
Credit goes to github.com

Skip to content

test/devices.bats: nits #4369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 3 commits into from
Dec 8, 2020
+15 −36
Merged

test/devices.bats: nits #4369

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7b910a0
test/devices.bats: skip earlier
kolyshkin Nov 13, 2020
a53c2a7
test/devices.bats: rm unneeded run
kolyshkin Nov 13, 2020
b3000eb
test/devices.bats: fix "additional device permissions" case
kolyshkin Nov 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 15 additions & 36 deletions test/devices.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@
load helpers

function setup() {
if test -n "$CONTAINER_UID_MAPPINGS"; then
skip "userNS enabled"
fi

setup_test
newconfig="$TESTDIR/config.json"
}
Expand All @@ -24,9 +28,6 @@ EOF
}

@test "additional devices support" {
if test -n "$CONTAINER_UID_MAPPINGS"; then
skip "userNS enabled"
fi
OVERRIDE_OPTIONS="--additional-devices /dev/null:/dev/qifoo:rwm" start_crio
pod_id=$(crictl runp "$TESTDATA"/sandbox_config.json)

Expand All @@ -40,13 +41,9 @@ EOF
@test "additional devices permissions" {
# We need a ubiquitously configured device that isn't in the
# OCI spec default set.
declare -r device="/dev/loop-control"
declare -r device="/dev/kmsg"
declare -r timeout=30

if test -n "$CONTAINER_UID_MAPPINGS"; then
skip "userNS enabled"
fi

if ! test -r $device; then
skip "$device not readable"
fi
Expand All @@ -66,26 +63,23 @@ EOF
if ! is_cgroup_v2; then
# Dump the deviced cgroup configuration for debugging.
output=$(crictl exec --timeout=$timeout --sync "$ctr_id" cat /sys/fs/cgroup/devices/devices.list)
[[ "$output" == *"c 10:237 w"* ]]
[[ "$output" == *"c 1:11 w"* ]]
fi

# Opening the device in read mode should fail because the device
# cgroup access only allows writes.
run crictl exec --timeout=$timeout --sync "$ctr_id" dd if=$device of=/dev/null count=1
run crictl exec --timeout=$timeout --sync "$ctr_id" head -1 $device
[ "$status" -ne 0 ]
[[ "$output" == *"Operation not permitted"* ]]

# The write should be allowed by the devices cgroup policy, so we
# should see an EINVAL from the device when the device fails it.
# TODO: fix that test, currently fails with "dd: can't open '/dev/loop-control': No such device non-zero exit code"
# run crictl exec --timeout=$timeout --sync "$ctr_id" dd if=/dev/zero of=$device count=1
# echo $output
# [[ "$output" == *"Invalid argument"* ]]
# The write should be allowed by the devices cgroup policy
run crictl exec --timeout=$timeout --sync "$ctr_id" sh -c "echo woohoo | tee $device"
[ "$status" -eq 0 ]
# check there's no error message of any kind from tee
[[ "$output" == "woohoo" ]]
}

@test "annotation devices support" {
if test -n "$CONTAINER_UID_MAPPINGS"; then
skip "userNS enabled"
fi
create_device_runtime
start_crio

Expand All @@ -102,10 +96,6 @@ EOF
}

@test "annotation should not be processed if not allowed" {
if test -n "$CONTAINER_UID_MAPPINGS"; then
skip "userNS enabled"
fi

start_crio

jq ' .annotations."io.kubernetes.cri-o.Devices" = "/dev/null:/dev/qifoo:rwm"' \
Expand All @@ -116,14 +106,10 @@ EOF
ctr_id=$(crictl create "$pod_id" "$TESTDATA"/container_redis.json "$TESTDATA"/sandbox_config.json)
crictl start "$ctr_id"

run crictl exec --sync "$ctr_id" sh -c "ls /dev/qifoo"
[ "$status" -ne 0 ]
! crictl exec --sync "$ctr_id" sh -c "ls /dev/qifoo"
}

@test "annotation should override configured additional_devices" {
if test -n "$CONTAINER_UID_MAPPINGS"; then
skip "userNS enabled"
fi
create_device_runtime

OVERRIDE_OPTIONS="--additional-devices /dev/urandom:/dev/qifoo:rwm" start_crio
Expand All @@ -142,9 +128,6 @@ EOF
}

@test "annotation should configure multiple devices" {
if test -n "$CONTAINER_UID_MAPPINGS"; then
skip "userNS enabled"
fi
create_device_runtime
start_crio

Expand All @@ -164,9 +147,6 @@ EOF
}

@test "annotation should fail if one device is invalid" {
if test -n "$CONTAINER_UID_MAPPINGS"; then
skip "userNS enabled"
fi
create_device_runtime
start_crio

Expand All @@ -175,6 +155,5 @@ EOF

pod_id=$(crictl runp "$newconfig")

run crictl create "$pod_id" "$TESTDATA"/container_redis.json "$TESTDATA"/sandbox_config.json
[ "$status" -ne 0 ]
! crictl create "$pod_id" "$TESTDATA"/container_redis.json "$TESTDATA"/sandbox_config.json
}