Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@kolyshkin
Copy link
Collaborator

What type of PR is this?

/kind failing-test

(this is not about failing-test; it's just I could not find any category which is closer to ci than this one)

What this PR does / why we need it:

Use cri-tools from git head for CI.

This is done so changes in cri-tools will be caught instantly
(as opposed to after a release).

Should help in finding bugs like the one fixed by kubernetes-sigs/cri-tools#683

Note this should only be done for master cri-o branch.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

This is done so changes in cri-tools will be caught instantly
(as opposed to after a release).

Note this should only be done for master cri-o branch.

Signed-off-by: Kir Kolyshkin <[email protected]>
@openshift-ci-robot openshift-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. labels Nov 14, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2020
@codecov
Copy link

codecov bot commented Nov 14, 2020

Codecov Report

Merging #4371 (1eddc1b) into master (f261f05) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4371   +/-   ##
=======================================
  Coverage   39.29%   39.29%           
=======================================
  Files         112      112           
  Lines        8835     8835           
=======================================
  Hits         3472     3472           
  Misses       4977     4977           
  Partials      386      386           

@kolyshkin
Copy link
Collaborator Author

/retest

Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
/retest

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kolyshkin, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [kolyshkin,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kolyshkin
Copy link
Collaborator Author

/retest

@openshift-merge-robot
Copy link
Contributor

@kolyshkin: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws 1eddc1b link /test e2e-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kolyshkin
Copy link
Collaborator Author

/retest

(seems that e2e-aws is broken badly)

@umohnani8
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2020
@umohnani8 umohnani8 merged commit 64db7ca into cri-o:master Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants