-
Notifications
You must be signed in to change notification settings - Fork 1.1k
ci: use cri-tools from git head #4371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is done so changes in cri-tools will be caught instantly (as opposed to after a release). Note this should only be done for master cri-o branch. Signed-off-by: Kir Kolyshkin <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #4371 +/- ##
=======================================
Coverage 39.29% 39.29%
=======================================
Files 112 112
Lines 8835 8835
=======================================
Hits 3472 3472
Misses 4977 4977
Partials 386 386 |
|
/retest |
saschagrunert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
/retest
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kolyshkin, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
@kolyshkin: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest (seems that e2e-aws is broken badly) |
|
/lgtm |
What type of PR is this?
/kind failing-test
(this is not about failing-test; it's just I could not find any category which is closer to ci than this one)
What this PR does / why we need it:
Use cri-tools from git head for CI.
This is done so changes in cri-tools will be caught instantly
(as opposed to after a release).
Should help in finding bugs like the one fixed by kubernetes-sigs/cri-tools#683
Note this should only be done for master cri-o branch.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?