image pull: close progress chan #4412
Conversation
so we don't leak a goroutine Signed-off-by: Peter Hunt <[email protected]>
|
fixes containers/image#1095 |
|
/cherry-pick release-1.20 |
|
@haircommander: once the present PR merges, I will cherry-pick it on top of release-1.20 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-1.19 |
|
@haircommander: once the present PR merges, I will cherry-pick it on top of release-1.19 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## master #4412 +/- ##
=======================================
Coverage 40.49% 40.50%
=======================================
Files 116 116
Lines 9329 9330 +1
=======================================
+ Hits 3778 3779 +1
Misses 5125 5125
Partials 426 426 |
|
Wow, nice catch! /lgtm |
saschagrunert
left a comment
There was a problem hiding this comment.
/retest
/lgtm
Thanks for the fix! 🙏
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@haircommander: new pull request created: #4413 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@haircommander: new pull request created: #4414 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
so we don't leak a goroutine
Signed-off-by: Peter Hunt [email protected]
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?