-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[release-1.20] image pull: close progress chan #4413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.20] image pull: close progress chan #4413
Conversation
so we don't leak a goroutine Signed-off-by: Peter Hunt <[email protected]>
Codecov Report
@@ Coverage Diff @@
## release-1.20 #4413 +/- ##
================================================
+ Coverage 38.72% 40.50% +1.77%
================================================
Files 111 116 +5
Lines 8702 9330 +628
================================================
+ Hits 3370 3779 +409
- Misses 4967 5125 +158
- Partials 365 426 +61 |
saschagrunert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: openshift-cherrypick-robot, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@openshift-cherrypick-robot: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This is an automated cherry-pick of #4412
/assign haircommander