Use the full sha value to name the bundle file #4587
Conversation
Signed-off-by: Harshal Patil <[email protected]>
|
Hi @harche. Thanks for your PR. I'm waiting for a cri-o member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## master #4587 +/- ##
=======================================
Coverage 40.63% 40.63%
=======================================
Files 115 115
Lines 9421 9421
=======================================
Hits 3828 3828
Misses 5162 5162
Partials 431 431 |
|
@harche: GitHub didn't allow me to request PR reviews from the following users: odinuge. Note that only cri-o members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
|
@odinuge: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harche, odinuge, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| mkdir -p "$ARCHIVE_PATH" | ||
|
|
||
| BUNDLE=crio-$(git describe --tags --exact-match 2>/dev/null || git rev-parse --short HEAD) | ||
| BUNDLE=crio-$(git describe --tags --exact-match 2>/dev/null || git rev-parse HEAD) |
There was a problem hiding this comment.
sounds good, in that case how would the complete download url look like? I want to make sure I got that correctly to update kubernetes/test-infra#20898
So if you are doing that in #4552, do we still need to have this PR open?
There was a problem hiding this comment.
I don't think that wee need this PR since I have to touch both lines in any case. :)
After this got merged, the complete download URL should look like:
https://storage.googleapis.com/k8s-conform-cri-o/artifacts/cri-o.amd64.$(git ls-remote https://github.com/cri-o/cri-o master | awk '{print $1}').tar.gz
Not sure if we can avoid the awk invocation.
There was a problem hiding this comment.
Ah maybe just by using cut -f1 instead of awk.
There was a problem hiding this comment.
Alright, then I will close this PR and update kubernetes/test-infra#20898 with the new url and put that one on the hold until #4552 is merged.
|
/hold |
|
@harche: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Closing after this discussion, #4587 (comment) /close |
|
@harche: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Harshal Patil [email protected]
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #4586
Special notes for your reviewer:
Does this PR introduce a user-facing change?